1199579 - Eslint cleanup of inplace-editor

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1199579.patch

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8653950 [details] [diff] [review]
1199579.patch

Review of attachment 8653950 [details] [diff] [review]:
-----------------------------------------------------------------

Nice clean up!

::: browser/devtools/shared/inplace-editor.js
@@ +190,5 @@
> +  this.destroy = options.destroy;
> +  this.initial = options.initial ? options.initial : this.elt.textContent;
> +  this.multiline = options.multiline || false;
> +  this.trimOutput = options.trimOutput === undefined ?
> +                    true : !!options.trimOutput;

nit: I think it's clearer when these are formatted like this:

this.trimOutput = options.trimOutput === undefined
                  ? true
                  : !!options.trimOutput;

(if bugzilla doesn't preserve the indentation, I'm vertically aligning ? below options, and : below ?)

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1199579.patch [1.0]

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=00a0645f56f6

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0fa63b2ccea0

Comment 6

[:Gijs (he/him)]

(In reply to Gabriel Luong [:gl] from comment #4)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=00a0645f56f6

This had dt1 failures...
(In reply to Pulsebot from comment #5)
> https://hg.mozilla.org/integration/fx-team/rev/0fa63b2ccea0

... and so did this. Backed out:

remote:   https://hg.mozilla.org/integration/fx-team/rev/5a42a522ae06

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1199579.patch [2.0]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a60b2d82a881

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a877d212f6b0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a877d212f6b0