Closed Bug 1199639 Opened 6 years ago Closed 6 years ago

about:addons should return "The address isn't valid" for guest mode session

Categories

(Firefox for Android Graveyard :: General, defect)

43 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox42 affected, firefox43 verified)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox42 --- affected
firefox43 --- verified

People

(Reporter: TeoVermesan, Assigned: sebastian)

Details

Attachments

(1 file)

Tested with:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 43.0a1 (2015-08-27)

Steps to reproduce:
1. Open Firefox and enter guest mode
2. Enter about:addons in URL Bar

Actual results:
- add-on manager is displayed and by choosing "Browse all Firefox Add-ons", https://addons.mozilla.org/en-US is displayed

Expected results:
- about:addons is not present anymore in Menu -> Tools, so about:addons should not be accessed 
- "This address isn't valid" should be displayed, when about:addons is loaded.
Are you able to install any add-ons?

I'm worried about spending too much time blocking this URL. People can always just manually go to https://addons.mozilla.org by typing in the URLbar. I think the core issue is making sure add-on installation is blocked.
On Aurora, when tapping "Add to Firefox" for installing an add-on, a message is displayed " X could not be installed because it is not compatible with Aurora 42.0a2". On Nightly, nothing happens when tapping "Add to Firefox"
We implemented this for restricted profiles and it should be quite easy to extend this to guest profiles.
Assignee: nobody → s.kaspari
Bug 1199639 - Block access to about:addons for guest profiles. r?mhaigh
Attachment #8654120 - Flags: review?(mhaigh)
Status: NEW → ASSIGNED
Attachment #8654120 - Flags: review?(mhaigh) → review+
Comment on attachment 8654120 [details]
MozReview Request: Bug 1199639 - Block access to about:addons for guest profiles. r?mhaigh

https://reviewboard.mozilla.org/r/17625/#review15983
https://hg.mozilla.org/mozilla-central/rev/ea037342780d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
about:addons returns "The address wasn't understood" for guest mode session
Tested with:
Device: Nexus 4 (Android 5.1)
Build: Firefox for Android 43.0a1 (2015-09-03)
about:config and about:addons both return "The address wasn't understood".
about:apps returns "The address isn't valid".

I think that the result should be consistent for all about:pages
(In reply to Teodora Vermesan (:TeoVermesan) from comment #9)
> about:config and about:addons both return "The address wasn't understood".
> about:apps returns "The address isn't valid".
> 
> I think that the result should be consistent for all about:pages

This is different. about:apps has been completely removed (See bug 1179872) - even for non-restricted profiles.
Tested using:
Device: LG G4 (Android 5.1)
Build: Firefox for Android 43.0a2 (2015-09-22)

In guest mode, about:addons returns "The address wasn't understood".
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.