1199639 - about:addons should return "The address isn't valid" for guest mode session

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 43.0a1 (2015-08-27)

Steps to reproduce:
1. Open Firefox and enter guest mode
2. Enter about:addons in URL Bar

Actual results:
- add-on manager is displayed and by choosing "Browse all Firefox Add-ons", https://addons.mozilla.org/en-US is displayed

Expected results:
- about:addons is not present anymore in Menu -> Tools, so about:addons should not be accessed 
- "This address isn't valid" should be displayed, when about:addons is loaded.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Are you able to install any add-ons?

I'm worried about spending too much time blocking this URL. People can always just manually go to https://addons.mozilla.org by typing in the URLbar. I think the core issue is making sure add-on installation is blocked.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

On Aurora, when tapping "Add to Firefox" for installing an add-on, a message is displayed " X could not be installed because it is not compatible with Aurora 42.0a2". On Nightly, nothing happens when tapping "Add to Firefox"

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

We implemented this for restricted profiles and it should be quite easy to extend this to guest profiles.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1199639 - Block access to about:addons for guest profiles. r?mhaigh

Bug 1199639 - Block access to about:addons for guest profiles. r?mhaigh

Comment 5

[Martyn Haigh (:mhaigh)]

Comment on attachment 8654120 [details]
MozReview Request: Bug 1199639 - Block access to about:addons for guest profiles. r?mhaigh

https://reviewboard.mozilla.org/r/17625/#review15983

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ea037342780d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea037342780d

Comment 8

[Teodora Vermesan (:TeoVermesan)]

about:addons returns "The address wasn't understood" for guest mode session
Tested with:
Device: Nexus 4 (Android 5.1)
Build: Firefox for Android 43.0a1 (2015-09-03)

Comment 9

[Teodora Vermesan (:TeoVermesan)]

about:config and about:addons both return "The address wasn't understood".
about:apps returns "The address isn't valid".

I think that the result should be consistent for all about:pages

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #9)
> about:config and about:addons both return "The address wasn't understood".
> about:apps returns "The address isn't valid".
> 
> I think that the result should be consistent for all about:pages

This is different. about:apps has been completely removed (See bug 1179872) - even for non-restricted profiles.

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Tested using:
Device: LG G4 (Android 5.1)
Build: Firefox for Android 43.0a2 (2015-09-22)

In guest mode, about:addons returns "The address wasn't understood".