Closed Bug 1199644 Opened 4 years ago Closed 4 years ago

New widths for the two sections of about:privatebrowsing in Firefox 42

Categories

(Firefox :: Private Browsing, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Iteration:
43.2 - Sep 7
Tracking Status
firefox42 --- verified
firefox43 --- wontfix

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(4 files)

See bug 1198287 comment 27.
Flags: qe-verify?
Bug 1199644 - New widths for the two sections of about:privatebrowsing in Firefox 42. r=bgrins
Attachment #8654088 - Flags: review?(bgrinstead)
Francesco, are the changes in the localization notes possible for Aurora?

We're reaching out to localizers about the width changes anyways, but if we can update the in-tree documentation it's better.
Flags: needinfo?(francesco.lodolo)
Yes, updating localization comment is fine (note that you'll still need to use the l10n flag to uplift, because it touches .dtd/.properties files).
Flags: needinfo?(francesco.lodolo)
Flags: qe-verify? → qe-verify+
(In reply to Francesco Lodolo [:flod] from comment #3)
> Yes, updating localization comment is fine (note that you'll still need to
> use the l10n flag to uplift, because it touches .dtd/.properties files).

I'm not familiar with the process, do you mean placing the late-l10n keyword on the bug?
Besides getting approval from release-driver, whoever commits this to aurora needs to add l10n={name-pf-release-driver-approving} to the commit message.

https://hg.mozilla.org/hgcustom/version-control-tools/file/f4661432e7c2/hghooks/mozhghooks/prevent_string_changes.py
Attachment #8654088 - Flags: review?(bgrinstead) → review+
Comment on attachment 8654088 [details]
MozReview Request: Bug 1199644 - New widths for the two sections of about:privatebrowsing in Firefox 42. r=bgrins

https://reviewboard.mozilla.org/r/17609/#review15743

Fine with me as long as you have sign off for changing the entity value without updating the name
Comment on attachment 8654088 [details]
MozReview Request: Bug 1199644 - New widths for the two sections of about:privatebrowsing in Firefox 42. r=bgrins

Approval Request Comment
[Feature/regressing bug #]: New about:privatebrowsing landing page
[User impact if declined]: Sub-optimal design on a very visible page
[Describe test coverage new/current, TreeHerder]: Aurora-only version of bug 1198287, will do QA on the branch
[Risks and why]: Limited to the page
[String/UUID change made/needed]: Changed entity contents but not entity names
Attachment #8654088 - Flags: approval-mozilla-aurora?
Comment on attachment 8654088 [details]
MozReview Request: Bug 1199644 - New widths for the two sections of about:privatebrowsing in Firefox 42. r=bgrins

New feature, we want to polish it, taking it.
Attachment #8654088 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
QA Contact: paul.silaghi
I've tried some random locales. Possible issues:
RU - private browsing section smaller than the tracking protection section
IT - tracking protection section higher
FR - private browsing section smaller than the tracking protection section, also both sections larger than usual
Flags: needinfo?(paolo.mozmail)
Francesco, I think we have now landed almost all the styling and text changes to about:privatebrowsing.

Can you recommend the best way to get in touch with localizers about the changes?
Flags: needinfo?(paolo.mozmail) → needinfo?(francesco.lodolo)
Flags: needinfo?(francesco.lodolo) → needinfo?(l10n)
I think I got this covered in https://groups.google.com/forum/#!topic/mozilla.dev.l10n/5wPH8xOLIVE, feel free to add to it.
Flags: needinfo?(l10n)
So, what's left to be done here ?
Flags: needinfo?(paolo.mozmail)
I just wanted to note that I've been in touch with Axel on the appearance of the about:privatebrowsing page in localized builds, but there doesn't seem to be any particular action left to do at this point. I think we are fine from a QA perspective.
Flags: needinfo?(paolo.mozmail)
Thanks, marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.