English copy review of the "Forgotten" and "Kept" headers of about:privatebrowsing in Firefox 42

VERIFIED FIXED

Status

()

defect
P1
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox42 verified, firefox43 wontfix)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 attachment)

In Firefox 43, we already revised the "Forgotten" and "Kept" headers of about:privatebrowsing to say "Not Saved" and "Saved" instead, in bug 1199168. This is the result of a detailed English copy review.

For the Firefox 42 launch, we would like to revise the "Forgotten" and "Kept" headers for English as well, and say "Not Saved" and "Saved". There is not a substantial difference in meaning, in fact some locales have already translated these words with the equivalent of "Not Saved" and "Saved".

Given that we accept that some locales may have translated this already as something more similar to "Forgotten" and "Kept", we would like to change only the English words on the Developer Edition channel, but keep the entity name in order not to break string freeze, similarly to what we would do with a spelling error. This is because we don't want to create a substantial amount of additional work for localizers.

We're also removing the lead sentence ("This window won't remember any history") from the XHTML file on the Developer Edition channel in any case (but obviously we won't remove the associated entity).
Iteration: --- → 43.2 - Sep 7
Flags: qe-verify-
Bug 1199650 - English copy review of the "Forgotten" and "Kept" headers of about:privatebrowsing in Firefox 42.
Francesco, does this patch to do the English-only word changes per comment 0 look good?
Flags: needinfo?(francesco.lodolo)
I'm not in love with it, but I guess we need to take it if you have to change English.

I'd suggest to make a list of the things that are changing in this window when you send the message to dev-l10n, so that localizers can make informed decisions.
Flags: needinfo?(francesco.lodolo)
(In reply to Francesco Lodolo [:flod] from comment #3)
> I'd suggest to make a list of the things that are changing in this window
> when you send the message to dev-l10n, so that localizers can make informed
> decisions.

Yeah, I'd like to trigger a quick QA cycle on the English version when we land the patches to see that it's all good and we're sure everything is like we want it to be, when we contact localizers.
Comment on attachment 8654092 [details]
MozReview Request: Bug 1199650 - English copy review of the "Forgotten" and "Kept" headers of about:privatebrowsing in Firefox 42.

Bug 1199650 - English copy review of the "Forgotten" and "Kept" headers of about:privatebrowsing in Firefox 42.
Attachment #8654092 - Flags: review?(bgrinstead)
Comment on attachment 8654092 [details]
MozReview Request: Bug 1199650 - English copy review of the "Forgotten" and "Kept" headers of about:privatebrowsing in Firefox 42.

https://reviewboard.mozilla.org/r/17613/#review15745

::: browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml
(Diff revision 1)
> -        <p>&aboutPrivateBrowsing.subtitle;</p>

This looks like an unintentional removal.  Did you intend to remove &aboutPrivateBrowsing.subtitle; here?

::: browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml:41
(Diff revision 1)
> -            <div class="list-header">&aboutPrivateBrowsing.info.forgotten;</div>
> +            <p class="list-header">&aboutPrivateBrowsing.info.forgotten;</p>

Why switching from <div> to <p>?
(In reply to Brian Grinstead [:bgrins] from comment #6)
> This looks like an unintentional removal.  Did you intend to remove
> &aboutPrivateBrowsing.subtitle; here?

No, it's intentional, we don't want the lead sentence anymore.

> Why switching from <div> to <p>?

And we need the default <p> margin back. The same changes are in the patch for Firefox 43.
(In reply to :Paolo Amadini from comment #7)
> (In reply to Brian Grinstead [:bgrins] from comment #6)
> > This looks like an unintentional removal.  Did you intend to remove
> > &aboutPrivateBrowsing.subtitle; here?
> 
> No, it's intentional, we don't want the lead sentence anymore.

Should the entity be removed, then?

> > Why switching from <div> to <p>?
> 
> And we need the default <p> margin back. The same changes are in the patch
> for Firefox 43.

Where is that patch again?
Bug 1199168 looks like the place with the patch for 43 m-c
See Also: → 1199168
Comment on attachment 8654092 [details]
MozReview Request: Bug 1199650 - English copy review of the "Forgotten" and "Kept" headers of about:privatebrowsing in Firefox 42.

https://reviewboard.mozilla.org/r/17613/#review15767

Since this is for 42 only, I guess it's expected to not remove the entity?  This patch is OK with me as long as it's OK with flod
Attachment #8654092 - Flags: review+
(In reply to Brian Grinstead [:bgrins] from comment #10)
> Since this is for 42 only, I guess it's expected to not remove the entity?

Yeah, that's correct.
Comment on attachment 8654092 [details]
MozReview Request: Bug 1199650 - English copy review of the "Forgotten" and "Kept" headers of about:privatebrowsing in Firefox 42.

Approval Request Comment
[Feature/regressing bug #]: New about:privatebrowsing landing page
[User impact if declined]: This change is required to match the English copy review
[Describe test coverage new/current, TreeHerder]: Aurora-only version of bug 1199168, will do QA on the branch
[Risks and why]: Limited to the page
[String/UUID change made/needed]: Changed entity contents but not entity names
Attachment #8654092 - Flags: approval-mozilla-aurora?
Comment on attachment 8654092 [details]
MozReview Request: Bug 1199650 - English copy review of the "Forgotten" and "Kept" headers of about:privatebrowsing in Firefox 42.

Let's take it! Thanks
Attachment #8654092 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Verified fixed FF 42.0a2 (2015-09-03) Win 7, Ubuntu 12.04, OS X 10.10
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.