1199692 - Clicking learn more for a tile navigates away in the same page and could make the tile unreachable

Status: RESOLVED INVALID

(Firefox :: New Tab Page, defect, P1)

Description

[Matthew Storm]

Hey Nan and Kevin, 

When you click to learn more on a content tile description and it take to the page explaining content it loads in the same page so the user looses the tile and can't click on it. 

Can we have the link open in a new tab so when the user clicks on it they still have a chance to click on the content?

Thanks, 

~Storm

Comment 1

[Nan Jiang [:nanj]]

Hey Matt,

There is no control on that behavior from the server side.
Looped in Marina as this has to do with Firefox, she might know what's the best solution to it.


Thanks,
Nan

Comment 2

[Ed Lee :Mardak]

This would be handled from Firefox.

Comment 3

[Ed Lee :Mardak]

This is especially bad for tiles with a frequency cap of 1, so the user wouldn't see the tile again.

Comment 4

[Marina Samuel [:emtwo]]

Attachment: Part 1: v1: Open 'Learn more' link in a new tab

I think just opening the link in a new tab avoids this issue.

Comment 5

[Ed Lee :Mardak]

Comment on attachment 8654212 [details] [diff] [review]
Part 1: v1: Open 'Learn more' link in a new tab

Test would be good to make sure this functionality persists.

Comment 6

[Marina Samuel [:emtwo]]

Attachment: Part 2: v1: Test

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8655011 [details] [diff] [review]
Part 2: v1: Test

>+    frecent_sites: ["classroom.google.com", ...
Probably could have just tested with a plain sponsored directory tile, but this works too.

>+  registerCleanupFunction(() => {
>+    NewTabUtils.isTopPlacesSite; origIsTopPlacesSite;
Missing an assignment operator.

>+    let onTabOpen = function(event) {
>+      container.removeEventListener("TabOpen", onTabOpen, false);
>+      let browser = gBrowser.getBrowserForTab(event.target);
>+      browser.addEventListener("load", () => {
>+        browser.removeEventListener("load", this, true);
>+        is(browser.currentURI.spec, "about:blank", "We opened 'about:blank' after clicking 'Learn more'");
>+        is(gBrowser.tabs.length, 3, "There are now 3 tabs open");
>+        is(gBrowser.getBrowserForTab(gBrowser.tabs[1]).currentURI.spec, "about:newtab", "about:newtab is still open");
Probably good hygiene to close the extra tab unless head_* closes extra tabs already.

>+  promise.then(() => { TestRunner.next; });
Should be able to just do promise.then(TestRunner.next)

Comment 8

[Marina Samuel [:emtwo]]

https://hg.mozilla.org/integration/fx-team/rev/a6b0cad8fbc20500db368415b76b065e9e14d612
Bug 1199692 - Open 'Learn more' link in a new tab. r=Mardak

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing frequent Win8 browser_private_search_perwindowpb.js timeouts followed by a cascade of other failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=4483253&repo=fx-team

https://hg.mozilla.org/integration/fx-team/rev/e5d0ef8da5b0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Screenshot in case it helps:
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/fx-team/sha512/db5ce8d62c0fea6958a77237cd55034040d0e820e4d9e11d7e90e1155665ceb06121be04804e5513914aac1552026cf348c222e33dd4ff11ef1c6132161cf7d5

Comment 11

[Marina Samuel [:emtwo]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7362d69ee390