Closed
Bug 1199734
Opened 9 years ago
Closed 9 years ago
ui-showcase doesn't need to load sdk - avoid errors loading TB.min.css
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox43 fixed)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
(Whiteboard: [tech-debt])
Attachments
(1 file)
1.48 KB,
patch
|
andreio
:
review+
|
Details | Diff | Splinter Review |
The ui-showcase is currently giving 404 errors trying to load TB.min.css. It gets a lot of these due to the way we reload with out panel frames. However, since we dropped using the sdk for layout, we no longer need to load any of the sdk for the ui-showcase. The places where the sdk may be required use a mock.
Assignee | ||
Comment 1•9 years ago
|
||
Simple patch to drop the loading of the sdk from the showcase. Might speed it up a little as well ;-)
Attachment #8654238 -
Flags: review?(andrei.br92)
Comment 2•9 years ago
|
||
Comment on attachment 8654238 [details] [diff] [review] Loop's ui-showcase doesn't need to load sdk - avoid errors loading TB.min.css Review of attachment 8654238 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! Does feel faster especially without the avalanche or warnings in the console :)
Attachment #8654238 -
Flags: review?(andrei.br92) → review+
Comment 3•9 years ago
|
||
While on the subject of removing. Any reason why we are still loading "../content/js/multiplexGum.js" in the ui-showcase?
Flags: needinfo?(standard8)
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Andrei Oprea [:andreio] from comment #3) > While on the subject of removing. Any reason why we are still loading > "../content/js/multiplexGum.js" in the ui-showcase? No idea, however, I've got a bug to remove that and the code associated with all of the old standalone call url stuff that we can do in a bit under 30 days, so I suggest we just leave it until then.
Flags: needinfo?(standard8)
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/94835d07fc0a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•