1199747 - Cannot build with external source for branding only

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Nathan Toone [:toonetown]]

I'd like to place my branding files external to the gecko source tree.  In order to do this (assuming my branding is in /path/to/my/branding), I have to do the following in my mozconfig:

    ac_add_options --with-external-source-dir=/path/to/my/
    ac_add_options --with-branding=branding

The "external-source-dir" is needed because /path/to/my/branding is not a subdirectory of $topdir - and there is an error without it.

However, when you specify "--with-external-source-dir", the configure script expects there to be an application at $EXTERNAL_SOURCE_DIR/$MOZ_BUILD_APP - which is *not* my case (I just want to have branding within my external source directory, and use the "main" tree for the actual application that is built - mobile/android, in my case).

I would suggest modifying line 3856 of configure.in (where it talks of adding support for comm-central).  Instead of doing the check:
    if test -n "$EXTERNAL_SOURCE_DIR"

I propose it be changed to:
    if test -n "$EXTERNAL_SOURCE_DIR" -a -d "$EXTERNAL_SOURCE_DIR/$MOZ_BUILD_APP"

That shouldn't affect any existing external source trees which already define the appropriate application, but it would allow for the situation I describe.

A patch is forthcoming

Comment 1

[Nathan Toone [:toonetown]]

Attachment: bug-1199747-fix.patch

Patch which adds the check.  Try server is busy right now, but I'll get it posted once my push succeeds.

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8654274 [details] [diff] [review]
bug-1199747-fix.patch

Redirecting to glandium and jcranmer.  I haven't a clue what implications this might have.

Comment 3

[Nathan Toone [:toonetown]]

Actually, this won't work the way I'm expecting either...so symbolic links it is!