1199768 - Long-pressing at top of page with URL bar hidden triggers URL bar context menu

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #956075 +++

Nexus S running recent nightly. STR:

1. Load a page (e.g. mozilla.org) and scroll down so that the URL bar scrolls off the screen.
2. Tap near the top of the screen (where the URL would have been)

Expected:
Tap is delivered to content

Actual:
URL bar is tapped and we end up on the URL entry screen.

Note that this is happening on current Aurora builds as well and is *not* a regression from bug 1180295. It's exactly the same bug as bug 956075 so that must have regressed at some point.

I looked at the code and it's almost certainly because the code in GeckoViewFlipper.java is calling ViewHelper.getTranslationY(this) when in fact the GeckoViewFlipper instance is inside a LinearLayout which is the actual thing with the translation. So calling ViewHelper.getTranslationY(getParent()) or some equivalent thing should fix this, but I haven't tried it yet.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Yup, that does the trick.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Not sure wesj will have time to review this given his new job?

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8654311 [details] [diff] [review]
Patch

Review of attachment 8654311 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable to me.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c21957fdcbee

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c21957fdcbee