1199773 - [Dialer] incoming call screen is inconsistent when phone lock state changes between viewing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
If the user receives a call on the lock screen, dismisses the call screen, unlocks the phone, and views the call screen again it will be the lockscreen version instead of the unlocked phone version of the call screen. this also occurs with the call being received while the phone is unlocked and then locking it and viewing the call screen.

Repro Steps:
1) Update a Aries to 20150828140025
2) Lock the phone
3) Receive a call
4) Press the home button to dismsiss call screen
5) Unlock the phone
6) Open the notification tray and select to tview the call screen
7) Observe call screen

Actual:
The call screen will be the version for the screen it was initially received

Expected:
It is expected that the call screen 

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150828140025
Gaia: fa15462b29258fdec8329bfc367e590022dbc9e5
Gecko: 008d4d76f387
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro frequency: 10/10
See attached: video clip(https://youtu.be/H51qjHJKDww), logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on flame 2.5 and Flame 2.2.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150828030207
Gaia: b69c16798ddd7154207f56d983721a327522f5d1
Gecko: 87e23922be37
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.2 [Full Flash]
Build ID: 20150826032503
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: 1effc4cb6414
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
The call screen will be the version for the screen it was initially received on

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Not a regression so not nominating to block on this.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1199773-callscreen-lockscreen-state-fix > mozilla-b2g:master

Comment 4

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8675683 [details] [review]
[gaia] gabrielesvelto:bug-1199773-callscreen-lockscreen-state-fix > mozilla-b2g:master

Once upon a time there must have been some synchronization between the callscreen and the lockscreen but the relevant code was either left over in the dialer or had bit-rotted. I've removed all the old cruft and consolidated the switching / layout in a single place.

Comment 5

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8675683 [details] [review]
[gaia] gabrielesvelto:bug-1199773-callscreen-lockscreen-state-fix > mozilla-b2g:master

Redirecting to Tamara.

Comment 6

[Tamara Hills [:thills]]

Comment on attachment 8675683 [details] [review]
[gaia] gabrielesvelto:bug-1199773-callscreen-lockscreen-state-fix > mozilla-b2g:master

Hi Gabriele,

this looks good.  I think it's a nice upgrade to the code and it reads easier after this.  It tested out fine too from my brief testing of the STR and few cases on multiple calls.

Thanks,
-tamara

Comment 7

[Gabriele Svelto [:gsvelto]]

I had to fix a linting issue before merging. Merged to gaia/master 217ee961b085fdf0fed52555b6761bf1d3d046a3

https://github.com/mozilla-b2g/gaia/commit/217ee961b085fdf0fed52555b6761bf1d3d046a3

Comment 8

[Lela(Leave from Mozilla)]

This bug has been verified as pass on latest build of Flame kk master 512mb and Aries kk master by the STR in comment 0.
Actual results: It is show the call screen.

See attachment: verified_Aries_master.3gp
Reproduce rate:0/10

Device: Aries kk master(pass) 
Build ID               20151206002630
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151205.234548
Firmware Date          Sat Dec  5 23:45:56 UTC 2015
Bootloader             s1

Device: Flame kk master 512mb (pass)
Build ID               20151206150208
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151206.184313
Firmware Date          Sun Dec  6 18:43:25 EST 2015
Firmware Version        v18d v4
Bootloader             L1TC000118D0

Comment 9

[Lela(Leave from Mozilla)]

Attachment: Verified video: Aries_master.3gp