Closed Bug 1199785 Opened 9 years ago Closed 9 years ago

Make atk methods in nsMaiInterfaceComponent.cpp to work with ipc proxies

Categories

(Core :: Disability Access APIs, defect)

36 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attached patch v1 (obsolete) — Splinter Review
So, do the same stuff on child process side when IPC is used as we do without IPC on parent side.

GetAccessibleWrap can now deal with atk_sockets too, though
IS_PROXY check wouldn't actually be needed for it atm, but made the code simpler, 
GetProxy just returns early if it isn't dealing with IS_MAI_OBJECT.


Making GetAccessibleWrap to deal with atk_sockets let me keep 
nsMaiInterfaceComponent.cpp simpler.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b03c72eec28f
Attachment #8655117 - Flags: review?(tbsaunde+mozbugs)
And the code is untested since I don't know how to trigger those code paths.

(e10s+a11y seemed to be working with the patch, and tabbing through child process was ok)
Attached patch v2Splinter Review
Attachment #8655117 - Attachment is obsolete: true
Attachment #8655117 - Flags: review?(tbsaunde+mozbugs)
Attachment #8655630 - Flags: review?(tbsaunde+mozbugs)
Attachment #8655630 - Flags: review?(tbsaunde+mozbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/10b4169ea9d2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: