Closed Bug 1199790 Opened 4 years ago Closed 4 years ago

Add sections and sorting for permissions in subpanel to match designs

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 43
Iteration:
43.2 - Sep 7
Tracking Status
firefox43 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

In https://bug1188356.bmoattachments.org/attachment.cgi?id=8639844 there are categories for permissions in the subpanel, including "Page functionality", "Plugins", and "System access".

I think "Plugins" make sense as a different section, but "Page functionality" and "System access" aren't as clear to me.  I've seen another mockup in invision that show some of the permissions moved from one place to another.

If we need to separate these, then we'll need a list of all possible permisisons and which category they belong to.  We will also need to update any new permissions that get added to the platform with this distinction.

An alternate idea is to sort permissions based on most used to least used (assuming we have that data) and put them all in a "Web platform" (or similarly named) section and then keep the "Plugins" section separate.
(In reply to Brian Grinstead [:bgrins] from comment #0)
> In https://bug1188356.bmoattachments.org/attachment.cgi?id=8639844 there are
> categories for permissions in the subpanel, including "Page functionality",
> "Plugins", and "System access".
> 
> I think "Plugins" make sense as a different section, but "Page
> functionality" and "System access" aren't as clear to me.  I've seen another
> mockup in invision that show some of the permissions moved from one place to
> another.
> 
> If we need to separate these, then we'll need a list of all possible
> permisisons and which category they belong to.  We will also need to update
> any new permissions that get added to the platform with this distinction.
> 
> An alternate idea is to sort permissions based on most used to least used
> (assuming we have that data) and put them all in a "Web platform" (or
> similarly named) section and then keep the "Plugins" section separate.

I think categories make it easier to find things than recency. We highlight changes from the default on the main panel as a parallel to surfacing most relevant but if the user wants to go see all of the permissions I think grouping by what each permission affects makes sense.

These are the categories:
PAGE FUNCTIONALITY
Web notifications
Set cookies
Load images
Pop-up windows
Install Add-ons



PLUG-INS
Adobe Flash
Adobe Acrobat
Silverlight
Quicktime
Java
WebEx64
Google Talk
Etc…

SYSTEM ACCESS
Push notifications
Full screen mode
Location
Camera
Microphone
Hide Mouse pointer
Store data on your computer
Flags: qe-verify?
Priority: -- → P1
Switching this to be an implementation bug to match the spec in Comment 1
Flags: qe-verify? → qe-verify+
Summary: UX: Figure out sections and sorting for permissions in subpanel → Add sections and sorting for permissions in subpanel to match designs
Whiteboard: [fxprivacy] → [fxprivacy][triage]
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Iteration: --- → 43.2 - Sep 7
Whiteboard: [fxprivacy][triage] → [fxprivacy]
(In reply to agrigas from comment #1)
> (In reply to Brian Grinstead [:bgrins] from comment #0)
> > In https://bug1188356.bmoattachments.org/attachment.cgi?id=8639844 there are
> > categories for permissions in the subpanel, including "Page functionality",
> > "Plugins", and "System access".
> > 
> > I think "Plugins" make sense as a different section, but "Page
> > functionality" and "System access" aren't as clear to me.  I've seen another
> > mockup in invision that show some of the permissions moved from one place to
> > another.
> > 
> > If we need to separate these, then we'll need a list of all possible
> > permisisons and which category they belong to.  We will also need to update
> > any new permissions that get added to the platform with this distinction.
> > 
> > An alternate idea is to sort permissions based on most used to least used
> > (assuming we have that data) and put them all in a "Web platform" (or
> > similarly named) section and then keep the "Plugins" section separate.
> 
> I think categories make it easier to find things than recency. We highlight
> changes from the default on the main panel as a parallel to surfacing most
> relevant but if the user wants to go see all of the permissions I think
> grouping by what each permission affects makes sense.
> 
> These are the categories:
> PAGE FUNCTIONALITY
> Web notifications
> Set cookies
> Load images
> Pop-up windows
> Install Add-ons


> 
> PLUG-INS
> Adobe Flash
> Adobe Acrobat
> Silverlight
> Quicktime
> Java
> WebEx64
> Google Talk
> Etc…
> 
> SYSTEM ACCESS
> Push notifications
> Full screen mode
> Location
> Camera
> Microphone
> Hide Mouse pointer
> Store data on your computer

Is this the intended sort order too, or should we stick with the existing sort (locale-dependent alphabetical sort) within each section?
Flags: needinfo?(agrigas)
A few small updates based on our discussion yesterday and an update from Philipp Sackl/Bill Maggs on Push. List is now:

PAGE FUNCTIONALITY
Send notifications
Set cookies
Pop-up windows
Install add-ons



PLUG-INS
Adobe Flash
Adobe Acrobat
Silverlight
Quicktime
Java
WebEx64
Google Talk
Etc…

SYSTEM ACCESS
Full screen mode
Location
Camera
Microphone
Hide Mouse pointer
Store data on your computer

Load images is removed and web and push notifications are combined into one permission called 'Send Notifications'
Flags: needinfo?(agrigas)
Alright, and what about the sort order (see Comment 3)?

Also, I think combining the two notifications permission is going to need to be another bug since they are actually two permissions in the backend and we would need to figure out how to display it if a user has different values for them for a site.
Flags: needinfo?(agrigas)
(In reply to Brian Grinstead [:bgrins] from comment #5)
> Alright, and what about the sort order (see Comment 3)?
> 
> Also, I think combining the two notifications permission is going to need to
> be another bug since they are actually two permissions in the backend and we
> would need to figure out how to display it if a user has different values
> for them for a site.

Stick with existing sort order - locale-dependant alpha
Flags: needinfo?(agrigas)
Bug 1199790 - Add grouping in Control Center Permissions subpanel;r=ttaubert
Attachment #8656197 - Flags: review?(ttaubert)
Comment on attachment 8656197 [details]
MozReview Request: Bug 1199790 - Add grouping in Control Center Permissions subpanel;r=ttaubert

https://reviewboard.mozilla.org/r/18111/#review16285

::: browser/modules/SitePermissions.jsm:29
(Diff revision 1)
> +  listPageFunctionalityPermissions: function() {

listPageFunctionalityPermissions() {

::: browser/modules/SitePermissions.jsm:41
(Diff revision 1)
> +  listSystemAccessPermissions: function() {

istSystemAccessPermissions() {

::: browser/modules/SitePermissions.jsm:41
(Diff revision 1)
> +  listSystemAccessPermissions: function() {
> +    let array = Object.keys(gPermissionObject).filter(p=> {
> +      return gPermissionObject[p].group == "systemaccess";
> +    });
> +    array.sort((a, b) => {
> +      return this.getPermissionLabel(a).localeCompare(this.getPermissionLabel(b));
> +    });
> +    return array;

We should probably have an internal function that covers this so that we could have:

listSystemAccessPermissions() {
  return this._listPermissionsByGroup(GROUP_SYSTEM_ACCESS);
}

::: browser/modules/SitePermissions.jsm:173
(Diff revision 1)
> +    group: "pagefunctionality",

It seems like it's worth defining those strings as constants, e.g. GROUP_PAGE_FUNCTIONALITY and then use that in the permissions definitions and the functions above.
Attachment #8656197 - Flags: review?(ttaubert) → review+
(In reply to agrigas from comment #4)
> Load images is removed

Let's handle removing the 'load images' permission in a separate bug
(In reply to Brian Grinstead [:bgrins] from comment #10)
> (In reply to agrigas from comment #4)
> > Load images is removed
> 
> Let's handle removing the 'load images' permission in a separate bug

Ok - do you want to create it or should I?
https://hg.mozilla.org/mozilla-central/rev/064a1ae9f3d4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
QA Contact: paul.silaghi
qe- since the permissions subpanel is going to be removed (bug 1203280)
Flags: qe-verify+ → qe-verify-
You need to log in before you can comment on or make changes to this bug.