1199864 - Convert checkbox in app_modal_dialog to use gaia-checkbox

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1199864_app_modal_dialog_checkbox > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8654445 [details] [review]
[gaia] KevinGrandon:bug_1199864_app_modal_dialog_checkbox > mozilla-b2g:master

Mike - wondering if you can give this a review since you reviewed bug 967402 and this is touching the same code. Mainly I just could not figure out a good way to actually surface the checkbox in the UI - wondering if you know a way?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8654445 [details] [review]
[gaia] KevinGrandon:bug_1199864_app_modal_dialog_checkbox > mozilla-b2g:master

You know, I don't think the checkbox happens ever in b2g. Theoretically Gecko could send a checkbox when displaying a custom dialog (like a "Don't ask me again" type thing), and I think the reasoning behind adding it in bug 967402 was that since we are handling the 'custom-dialog' modal event, we should handle anything gecko throws our way. But looking here [1] I couldn't find anything that uses it on the b2g side. For consistency I don't mind landing this, but I don't have strong feeling.

1.) https://mxr.mozilla.org/mozilla-central/ident?i=confirmEx

Comment 4

[Kevin Grandon :kgrandon]

Yeah, I don't know if or when this is used, but I'll go ahead and land for consistency (and to be able to remove building block usage).

Thanks for the review!

In master: https://github.com/mozilla-b2g/gaia/commit/04c089a1e520752e2769acac0e15d486d5b150b1