If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[AccessFu] Landmark traversal rule does not work

RESOLVED FIXED in Firefox 43

Status

()

Core
Disability Access APIs
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I guess that's what you get for not testing...
(Assignee)

Comment 1

2 years ago
Created attachment 8654460 [details] [diff] [review]
Keep match roles empty in BaseTraversalRules that don't provide roles.
Attachment #8654460 - Flags: review?(yzenevich)
(Assignee)

Updated

2 years ago
Assignee: nobody → eitan
Comment on attachment 8654460 [details] [diff] [review]
Keep match roles empty in BaseTraversalRules that don't provide roles.

Review of attachment 8654460 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just a question about the region role that's not a landmark in the spec.

::: accessible/jsat/Utils.jsm
@@ +421,5 @@
>        'contentinfo',
>        'main',
>        'navigation',
> +      'search',
> +      'region'

Region is not really a landmark AFAIK
Attachment #8654460 - Flags: review?(yzenevich) → review+
(Assignee)

Comment 3

2 years ago
(In reply to Yura Zenevich [:yzen] from comment #2)
> Comment on attachment 8654460 [details] [diff] [review]
> Keep match roles empty in BaseTraversalRules that don't provide roles.
> 
> Review of attachment 8654460 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, just a question about the region role that's not a landmark in
> the spec.
> 
> ::: accessible/jsat/Utils.jsm
> @@ +421,5 @@
> >        'contentinfo',
> >        'main',
> >        'navigation',
> > +      'search',
> > +      'region'
> 
> Region is not really a landmark AFAIK

I talked to Marco about this, and yeah, lets remove it from this rule. I'll introduce a "section" rule soon that will be more specific for android's "section navigation" and provide something useful.

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb4e82854ae7
https://hg.mozilla.org/mozilla-central/rev/bb4e82854ae7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.