1199884 - [AccessFu] Landmark traversal rule does not work

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

I guess that's what you get for not testing...

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Keep match roles empty in BaseTraversalRules that don't provide roles.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8654460 [details] [diff] [review]
Keep match roles empty in BaseTraversalRules that don't provide roles.

Review of attachment 8654460 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just a question about the region role that's not a landmark in the spec.

::: accessible/jsat/Utils.jsm
@@ +421,5 @@
>        'contentinfo',
>        'main',
>        'navigation',
> +      'search',
> +      'region'

Region is not really a landmark AFAIK

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Yura Zenevich [:yzen] from comment #2)
> Comment on attachment 8654460 [details] [diff] [review]
> Keep match roles empty in BaseTraversalRules that don't provide roles.
> 
> Review of attachment 8654460 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, just a question about the region role that's not a landmark in
> the spec.
> 
> ::: accessible/jsat/Utils.jsm
> @@ +421,5 @@
> >        'contentinfo',
> >        'main',
> >        'navigation',
> > +      'search',
> > +      'region'
> 
> Region is not really a landmark AFAIK

I talked to Marco about this, and yeah, lets remove it from this rule. I'll introduce a "section" rule soon that will be more specific for android's "section navigation" and provide something useful.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb4e82854ae7

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb4e82854ae7