Closed Bug 1199974 Opened 4 years ago Closed 4 years ago

libvpx fails to build on debian armel

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

This is fallout from bug 1194905. It turns out there's one case that does need -mfloat-abi=softfp, while most cases don't.
Comment on attachment 8654561 [details] [diff] [review]
Build libvpx neon code with -mfloat-abi=softfp when targetting ARM softfloat ABI

Review of attachment 8654561 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5437,5 @@
> +        dnl "softfloat" ABI, not the "softfp" ABI.
> +        dnl Note: VPX_ASFLAGS is also used in CFLAGS.
> +        AC_TRY_COMPILE([],
> +          [#ifndef __SOFTFP__
> +           #error "float-abi is either softfp or hardfp"

Maybe making this message read "compiler defaults to a NEON-compatible ABI, so we don't have to add extra flags" would make things clearer?  I was a little confused by the levels of negation to get to a positive result, but maybe that's just me.
Attachment #8654561 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/2cc300e791cc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.