Closed Bug 1199986 Opened 9 years ago Closed 9 years ago

[TV 2.5][Browser] User cannot use Back key to exit Settings page

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: cynthiatang, Assigned: yifan)

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(1 file)

[gaia] begeeben:1199986_user_cannot_use_back > mozilla-b2g:master
46 bytes, text/x-github-pull-request
selee
: review+
jocheng
: approval-gaia-v2.5+
Details | Review 
STR:
1. Launch Browser App
2. Go to Youtube
3. Add Youtube to the Bookmarks
4. Exit the Bookmarks

Actual: 
 - Pressing Esc key doesn't work.

Expected:
 - User can use Esc key to exit the Bookmarks
 - For Partner's devices, user can press Back key to exit the Bookmarks
Summary: [TV 2.5][Browser] User cannot use Back key to exit the Books → [TV 2.5][Browser] User cannot use Back key to exit the Bookmarks
Whiteboard: [ft:conndevices]
Summary: [TV 2.5][Browser] User cannot use Back key to exit the Bookmarks → [TV 2.5][Browser] User cannot use Back key to exit Bookmarks or Settings
QA Whiteboard: [COM=TV Browser]
Hi YiFan,
Can you check this issue? Thanks!
Flags: needinfo?(yliao)
Priority: -- → P1
Hi YiFan,
Over to you and feel free to reassign to Dan if you like.
Assignee: nobody → yliao
blocking-b2g: --- → 2.5+
status-b2g-v2.5: --- → affected
status-b2g-master: --- → affected
Flags: needinfo?(dhuang)
Dan, I think this bug is a duplicate of bug 1227041 . What do you think?
Assignee: yliao → dhuang
Flags: needinfo?(yliao)
I'll work on the ESC key for the settings page part.
Assignee: dhuang → yliao
Flags: needinfo?(dhuang)
Summary: [TV 2.5][Browser] User cannot use Back key to exit Bookmarks or Settings → [TV 2.5][Browser] User cannot use Back key to exit Settings page
Status: NEW → ASSIGNED
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
Attachment #8691747 - Flags: review?(selee)
Comment on attachment 8691747 [details] [review]
[gaia] begeeben:1199986_user_cannot_use_back > mozilla-b2g:master

LGTM!
Attachment #8691747 - Flags: review?(selee) → review+
Merged into master:
https://github.com/mozilla-b2g/gaia/commit/38cab3b9d4d5636a84d4bdc0c46d1088242a6c15
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8691747 [details] [review]
[gaia] begeeben:1199986_user_cannot_use_back > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: Can't exit settings with ESC
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=d89a52acd5eb556bb18aa0eca1f7b5e1abe74e3b
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none
Attachment #8691747 - Flags: approval-gaia-v2.5?
Comment on attachment 8691747 [details] [review]
[gaia] begeeben:1199986_user_cannot_use_back > mozilla-b2g:master

Approving for fixing bug on TV 2.5 browser feature.
Attachment #8691747 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Verified on 

==== Passed in Master branch ====
Commit 87fb9a4c60793fad569894bd888cfbe0d36e294f
Merge: 6dfb1a8 8c256c8
Author: Luke Chang <luke-chang@users.noreply.github.com>
Date:   Mon Jan 18 12:15:38 2016 +0800

==== Passed in v2.5 ====
commit 5988edd0ec51f539466fb61ba3b05e9add4413e1
Merge: 1dec9c2 3feaeac
Author: Fernando Jiménez Moreno <ferjmoreno@gmail.com>
Date:   Fri Jan 15 09:17:27 2016 +0100
Status: RESOLVED → VERIFIED
status-b2g-v2.5: fixed → verified
status-b2g-master: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: