1199989 - Add Tab Audio Indicator to SeaMonkey

Status: NEW

(SeaMonkey :: Tabbed Browser, enhancement)

Description

[rn10950]

As some of you may already know, Firefox 42 features a new "tab audio indicator", which places an icon on a tab that is currently playing sound. I took a look at the Firefox bug that introduces the feature (bug 486262), and it looks simple enough for us to implement in SeaMonkey. I have no idea if you guys want to add this, preferably as an optional component, as a preference currently exists for it. (browser.tabs.showAudioPlayingIcon) I am interested in doing the porting work for this.

Comment 1

[Philip Chee]

> I am interested in doing the porting work for this.
Great! Please go ahead!

Comment 2

[rn10950]

I am looking into porting this over, and I hit a roadblock. I'm looking at the Firefox patch, and I see a XUL image element in the XUL for the tab itself. Looking in tabbrowser.xml, I can't find an equivalent place to put this code. Here's the code in the Firefox patch, which belongs at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#5869 

> <xul:image xbl:inherits="soundplaying,pinned"
>	class="tab-icon-sound"
>	role="presentation"/>

I looked at the SM version of this file, and could not find any equivalent sections of XUL/XBL that I could insert this image into. The closest I came is http://mxr.mozilla.org/comm-central/source/suite/browser/tabbrowser.xml#71 with

>	   <xul:tabs class="tabbrowser-tabs" closebutton="true" flex="1"
>                     anonid="tabcontainer"
>                     tooltiptextnew="&newTabButton.tooltip;"
>                     tooltiptextclose="&closeTabButton.tooltip;"
>                     tooltiptextalltabs="&listAllTabs.tooltip;"
>                     setfocus="false"
>                     onclick="this.parentNode.parentNode.parentNode.onTabClick(event);"
>                     xbl:inherits="onnewtab,onnewtabclick"
>                     onclosetab="var node = this.parentNode;
>                                 while (node.localName != 'tabbrowser')
>                                   node = node.parentNode;
>                                 node.removeCurrentTab();">
>             <xul:tab selected="true" validate="never"
>                      onerror="this.parentNode.parentNode.parentNode.parentNode.addToMissedIconCache(this.getAttribute('image'));
>                               this.removeAttribute('image');"
>                      width="0" flex="100"
>                      class="tabbrowser-tab" label="&untitledTab;" crop="end"/>
>           </xul:tabs>

but, it still doesn't feel like the right place to put this.

Do you have any ideas?

Comment 3

[Frank-Rainer Grahl (:frg)]

Not a good first bug