1200043 - home button broken when OTA update screen showing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::System UI, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

User-Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

And if it is intentional, then we should just hide it, instead of presenting the user with ui that doesn't work as expected.

Comment 1

[Mahendra Potharaju [:mahe]]

Kevin, Can you confirm this and document STR please.

Comment 2

[Duane Dixon [:ddixon]]

Description: When there is an OTA update available, the user is able to navigate to the notification via the utility tray.  However, once at the OTA update screen the user cannot navigate to the homescreen by pressing the home button.  Pressing the home button causes the device to vibrate, but fails to show the home screen. 

Repro Steps:
1) Establish a Wifi or data connection
2) Go to Settings>Device Information>Check Now
3) Pull down utility tray and select the " (X) updates available" notification
4) Press home button

Actual:
Pressing home button causes phone to vibrate, but fails to navigate back to homescreen.

Expected:
Pressing the home button causes the phone to vibrate and allows the user to navigate back to the homescreen. 

Device: Aries 2.5
BuildID: 20150831112343
Gaia: 31e595f86f6bf159b3a9a46816a6ac00a55ca9f9
Gecko: ee6d6f239fb1ce935322504e0ea8de95e381fc1b
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro frequency: 5/5, 100%

See attached: logcat, video (http://youtu.be/lKLb3-Jvhwo)

Comment 3

[Duane Dixon [:ddixon]]

Attachment: home_button_logcat.txt

Comment 4

[Duane Dixon [:ddixon]]

Branch Check:

Issue DOES occur in Aries 2.5, Flame 2.5, and Flame 2.2 builds.  

Device: Aries 2.5
BuildID: 20150831112343
Gaia: 31e595f86f6bf159b3a9a46816a6ac00a55ca9f9
Gecko: ee6d6f239fb1ce935322504e0ea8de95e381fc1b
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.5
Build ID: 20150828054947
Gaia: fa15462b29258fdec8329bfc367e590022dbc9e5
Gecko: 008d4d76f387b722fbee151e1c9e1501482054e5
Version: 43.0a1 (Master)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.2
BuildID: 20150826191108
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: 16d864d163de
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Not sure.  I'm using a build with custom build : https://github.com/mozilla/gecko-dev/commits/325659e


I hit the notification and then downloaded the update.  
I was able to hit home when asked to update or save til later, following that I couldn't get update; the notification was stuck on uncompressing. 

I'm not sure if this is the same bug or if it's a different screen.  Asking D if I should file a separate bug or not.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note there are two update screens.  One to start the download and one to update the system.

Comment 7

[Dietrich Ayala (:dietrich)]

Naoki, file a separate bug for that. I've seen it too.

This bug is just to make the SHB hidden when in these screens, or to make the home button work correctly... whichever is decided to be the correct solution.

Comment 8

[Gregor Wagner [:gwagner]]

Can QA still reproduce? We fixed a bunch of SHB issues.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] jedireza:home-button-cancel-update-dialog > mozilla-b2g:master

Comment 10

[Reza Akhavan [:jedireza]]

Comment on attachment 8682151 [details] [review]
[gaia] jedireza:home-button-cancel-update-dialog > mozilla-b2g:master

All green:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b284827186531823732ddfc23940d9d4f89ccd10

Comment 11

[Alberto Pastor [:albertopq]]

Comment on attachment 8682151 [details] [review]
[gaia] jedireza:home-button-cancel-update-dialog > mozilla-b2g:master

We need, at least, unit tests covering this. Flag me again when added, please! Thanks!

Comment 12

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Gregor Wagner [:gwagner] from comment #8)
> Can QA still reproduce? We fixed a bunch of SHB issues.

This issue is still reproducible on latest Aries central. On the update available screen (same screen mentioned at comment 2), tapping on Home does not make the overlay go away (it does appear to return home in the background, however the overlay is obscuring this action).

Tested on:
Device: Aries
BuildID: 20151103140850
Gaia: 06de78d2c61c084956640c480280ba518b2fe29f
Gecko: 59a6ad6a921f4809dfc37d943d765300c65721e5
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6 Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Comment 13

[Reza Akhavan [:jedireza]]

Comment on attachment 8682151 [details] [review]
[gaia] jedireza:home-button-cancel-update-dialog > mozilla-b2g:master

Thanks Alberto. I added a couple unit tests for the new events we're listening for.

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b7f053a258c5b54875fe7041f9789c7bdec52eb7

Comment 14

[Alberto Pastor [:albertopq]]

Comment on attachment 8682151 [details] [review]
[gaia] jedireza:home-button-cancel-update-dialog > mozilla-b2g:master

LGTM! Thanks for the tests! :)

Comment 15

[Reza Akhavan [:jedireza]]

Comment on attachment 8682151 [details] [review]
[gaia] jedireza:home-button-cancel-update-dialog > mozilla-b2g:master

On master:
https://github.com/mozilla-b2g/gaia/commit/5c5717f893162f56baa578bf5b6b90cdaf0ff6fd

I rebased before merging to make sure treeherder was all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=28711de510ebf9bb3c16c5303d92961010d44d31

Comment 16

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as "pass" on the latest build of Aries KK v2.6 and Flame KK v2.6 512mb by the STR in comment 0.

Actual results: Pressing the home button, screen navigate back to the homescreen. 

See attachment: Verified_Aries_KK_v2.6_upd.png
Reproduce rate: 0/10

Device: Aries KK v2.6 (master)(Pass)
Build ID               20151109151826
Gaia Revision          23cab7ea0fcecab7689d340baf604e024e88f9a3
Gaia Date              2015-11-09 06:13:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e1ef2be156de1dad31bb4189a51b178b12b23340
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151109.143842
Firmware Date          Mon Nov  9 14:38:50 UTC 2015
Bootloader             s1

Device: Flame KK v2.6 512mb (master)(Pass)
Build ID               20151109150204
Gaia Revision          23cab7ea0fcecab7689d340baf604e024e88f9a3
Gaia Date              2015-11-09 06:13:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e1ef2be156de1dad31bb4189a51b178b12b23340
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.182508
Firmware Date          Mon Nov  9 18:25:22 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0