1200047 - [DLNAPlayer] Convert usage of toolbars.css to use tabs.css

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Kevin Grandon :kgrandon]

This will unify implementation across the OS and allow us to eventually easily switch to using web components.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1200047_tv_toolbar_usage > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8654639 [details] [review]
[gaia] KevinGrandon:bug_1200047_tv_toolbar_usage > mozilla-b2g:master

Hi John,

I haven't done much TV work, but I would like to keep it up with the rest of gaia, as far as removing building blocks goes.

I couldn't find out how to actually launch this app in the TV interface, so I'm not sure how well this patch will work. Could you either provide some guidance about how to launch this app, or take over this patch? Thank you!

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8654639 [details] [review]
[gaia] KevinGrandon:bug_1200047_tv_toolbar_usage > mozilla-b2g:master

Rex,

Please test it and give the feedback. Thanks.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Sorry I'm busy these days so I have to postpone testing this patch.
DLNA player is written to prove the concept of presentation API, but it's not a committed feature on any version roadmap for now.
If you would like to test it, you can erase the role "system" in manifest.webapp.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8654639 [details] [review]
[gaia] KevinGrandon:bug_1200047_tv_toolbar_usage > mozilla-b2g:master

Thank you for he help. With those tips I was able to open the app to make sure everything still works properly.

I would like to land this, so please review when you get a chance. Doing this will allow us to discontinue the legacy building blocks in favor of a web component in the future instead. Thanks!

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8654639 [details] [review]
[gaia] KevinGrandon:bug_1200047_tv_toolbar_usage > mozilla-b2g:master

Rex's review is enough. Thanks

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8654639 [details] [review]
[gaia] KevinGrandon:bug_1200047_tv_toolbar_usage > mozilla-b2g:master

Since this is only for a developer test app, and KM seems quite busy, I'm going to move forward with landing this.

I was able to test this and everything seemed to work fine. Please let me know if you spot any problems with it and I will follow-up. Thanks!

Comment 8

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/39b14276c01c127da9f63e9d69acc9abf50ce133