1200075 - Fix malloc_usable_size situation for SQLite on Windows

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nicholas Nethercote [inactive]]

Windows builds of SQLite warn about malloc_usable_size not being available.
This is because we set HAVE_MALLOC_USABLE_SIZE and SQLITE_WITHOUT_MSIZE due to
mozglue exposing malloc_usable_size.

glandium says the fix is to add this:

> ['-FI', TOPOBJDIR + '/dist/include/mozmemory.h'] 

to CFLAGS in the branch that adds HAVE_MALLOC_USABLE_SIZE/SQLITE_WITHOUT_MSIZE,
in db/sqlite3/src/moz.build.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1200075 - Do not avoid sqlite3 using _msize.

It was setup this way in bug 719579 for legitimate reasons (because
_msize would end up using the system symbol, which would crash trying to
get the size information from jemalloc allocations), but these reasons
don't apply anymore: back then the linking situation was different, and
nowadays, mozglue.dll exports its own _msize which plugs into
mozjemalloc, and sqlite is folded into nss3.dll, which links against
mozglue.dll, such that using _msize on mozjemalloc allocations works.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44ea5049ca21
Do not avoid sqlite3 using _msize. r=froydnj

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/44ea5049ca21