1200097 - Fix warnings in logalloc

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Nicholas Nethercote [inactive]]

FdPrintf.c has one warning that shows up in two different directories.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Fix warnings in logalloc

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8654701 [details] [diff] [review]
Fix warnings in logalloc

Review of attachment 8654701 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/replace/logalloc/FdPrintf.cpp
@@ +125,5 @@
>    // See comment in FdPrintf.h as to why WriteFile is used.
>    DWORD written;
>    WriteFile(reinterpret_cast<HANDLE>(aFd), buf, b - buf, &written, nullptr);
>  #else
> +  mozilla::unused << write(aFd, buf, b - buf);

Ideally, this should just actually care about the result (especially if it's -1 and errno is EINTR). But meh.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd30c9b6ee53

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd30c9b6ee53

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

My OS X debug build stopped working (linking) after this change, with this error:

 0:26.48 /Users/msreckovic/Repos/mozilla-central/obj-x86_64-apple-darwin13.4.0/memory/replace/logalloc/tmp40oq0x.list:
 0:26.49     lock_impl_posix.o
 0:26.49     FdPrintf.o
 0:26.49     LogAlloc.o
 0:26.49 
 0:26.49 Undefined symbols for architecture x86_64:
 0:26.49   "mozilla::unused", referenced from:
 0:26.49       FdPrintf(long, char const*, ...) in FdPrintf.o
 0:26.49 ld: symbol(s) not found for architecture x86_64
 0:26.49 clang: error: linker command failed with exit code 1 (use -v to see invocation)

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

I see, it's bug 1200623.