1200104 - "Collapse sidebar" faulty when pane is below tree

Status: RESOLVED DUPLICATE of bug 1189492

(DevTools :: Inspector, defect)

Description

[Geoff Lankow (:darktrojan)]

If the toolbox is so narrow that the tree and sidebar are vertically stacked, the "collapse sidebar" button doesn't work as intended. Instead it makes the pane wider and overflow the window.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Expanded pane, collapsed pane

Here's a screenshot.

Comment 2

[Patrick Brosset <:pbro>]

Ah, good catch. The intention was that this button should be hidden entirely when the sidebar is displayed below the inspector (vertically stacked), and this actually happens correctly when you switch to side docking, but it doesn't happen when you resize the toolbox as explained in comment 0.

This is where the button gets hidden:
https://dxr.mozilla.org/mozilla-central/rev/f2518b8a7b97b5bb477e94bc9131584007aac887/browser/devtools/inspector/inspector-panel.js#946

The other solution would be to keep the button but make it collapse the sidebar to the bottom rather than to the side, but that's for another bug.

Comment 3

[Geoff Lankow (:darktrojan)]

Originally I thought the lack of a button when docked to the side was a bug too and was going to file it until I saw that it was deliberate. Personally I think the function is so useful it should always be available.

Comment 4

[Patrick Brosset <:pbro>]

Good point, I've filed bug 1200179