[Messages][Tests] ThreadGenerator should be able to create threads with MMS

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: azasypkin, Assigned: azasypkin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sms-sprint-FxOS-S6])

Attachments

(1 attachment)

In this bug we want to add MMS support (especially MMS attachments) to ThreadGenerator so that we can pre-populate test storage with them.
Created attachment 8654714 [details] [review]
[gaia] azasypkin:bug-1200116-mms-in-tests > mozilla-b2g:master
Comment on attachment 8654714 [details] [review]
[gaia] azasypkin:bug-1200116-mms-in-tests > mozilla-b2g:master

Hey Julien,

How does it look to you?

Thanks!
Attachment #8654714 - Flags: review?(felash)
Whiteboard: [sms-sprint-FxOS-S6]
Comment on attachment 8654714 [details] [review]
[gaia] azasypkin:bug-1200116-mms-in-tests > mozilla-b2g:master

r=me with some nits
Please wait for a green try before merging.

Let's land this and iterate if we need better (but it's already pretty good!)
Attachment #8654714 - Flags: review?(felash) → review+
Thanks for super fast review! Nits fixed, treeherder is green, so landed:

https://github.com/mozilla-b2g/gaia/commit/441ed0ae5700a31d5130baae9090c19bc9dfea66
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.