1200134 - [USSD] Define State Transitions of USSD Session in TelephonyService. (Gecko part of Bug 1198676)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch: Control USSD Sessions with State-Transitions instead of Boolean.

Create this bug to address the problem in gecko side of bug 1198676.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8654741 [details] [diff] [review]
Patch: Control USSD Sessions with State-Transitions instead of Boolean.

Hi Edgar,

Per discussed in bug 1198676 comment 8,
I'd like to define the states of the USSD session instead of boolean to handle the cancelling of the USSD session gracefully.

May I have your review for this change?

Thanks!

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8654741 [details] [diff] [review]
Patch: Control USSD Sessions with State-Transitions instead of Boolean.

Review of attachment 8654741 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you.

::: dom/telephony/gonk/TelephonyService.js
@@ +2452,4 @@
>  
> +    if (oldSession != USSD_SESSION_ONGOING &&
> +        this._ussdSessions[aClientId] != USSD_SESSION_ONGOING &&
> +        !aMessage) {

Please add some comments about we mean to suppress the session end with empty message if user already cancel the session.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch: Control USSD Sessions with State-Transitions instead of Boolean. r=echen

address comment 2.

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Update try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f3c7322d841

Comment 5

[Carsten Book [:Tomcat]]

seems this doesn't apply to b2g-i cleanly:

Parsing... done
adding 1200134 to series file
renamed 1200134 -> 1200134_final.patch
applying 1200134_final.patch
patching file dom/telephony/gonk/TelephonyService.js
Hunk #3 FAILED at 1069
Hunk #4 FAILED at 2153
2 out of 5 hunks FAILED -- saving rejects to file dom/telephony/gonk/TelephonyService.js.rej

could you take a look, thanks!

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Carsten Book [:Tomcat] from comment #5)
> seems this doesn't apply to b2g-i cleanly:
> 
> Parsing... done
> adding 1200134 to series file
> renamed 1200134 -> 1200134_final.patch
> applying 1200134_final.patch
> patching file dom/telephony/gonk/TelephonyService.js
> Hunk #3 FAILED at 1069
> Hunk #4 FAILED at 2153
> 2 out of 5 hunks FAILED -- saving rejects to file
> dom/telephony/gonk/TelephonyService.js.rej
> 
> could you take a look, thanks!

Sorry about that.
I'll check what was happened in b2g-i.
Keep NI on me.

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

The patch can be merged after the following revision:
https://hg.mozilla.org/integration/b2g-inbound/rev/1e1fa696e2b6

I can merge it in latest b2g-inbound now.

Please give another trial, thank!

Comment 8

[Carsten Book [:Tomcat]]

(In reply to Bevis Tseng[:bevistseng][:btseng] from comment #7)
> The patch can be merged after the following revision:
> https://hg.mozilla.org/integration/b2g-inbound/rev/1e1fa696e2b6
> 
> I can merge it in latest b2g-inbound now.
> 
> Please give another trial, thank!

worked great, did the checkin! thanks!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/6611408430fb

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6611408430fb