Closed Bug 1200143 Opened 9 years ago Closed 9 years ago

[Settings] code maintenance

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gasolin, Assigned: gasolin)

Details

Attachments

(1 file)

[gaia] gasolin:issue-1200143 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review 
update document, syntax, ...etc. to get cleaner code base
Assignee: nobody → gasolin
Comment on attachment 8654787 [details] [review]
[gaia] gasolin:issue-1200143 > mozilla-b2g:master

@yura could you help review the patch?
Attachment #8654787 - Flags: review?(yzenevich)
Comment on attachment 8654787 [details] [review]
[gaia] gasolin:issue-1200143 > mozilla-b2g:master

Looks good with a couple of nits.
Attachment #8654787 - Flags: review?(yzenevich) → review+
issue addressed and merged https://github.com/mozilla-b2g/gaia/commit/0fd114af2f0a092715370af7c1c5ee406f4aef89

thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: