Closed Bug 1200161 Opened 9 years ago Closed 8 years ago

Comments are not escaped properly in the communication dashboard

Categories

(Marketplace Graveyard :: Reviewer Tools, defect, P4)

Avenir
defect

Tracking

(Not tracked)

VERIFIED FIXED
2016-03-29

People

(Reporter: alexis+bugs, Assigned: ashort)

Details

(Whiteboard: [ktlo])

Attachments

(2 files)

Attached image brrrrr.png
When submitting new entries in the communication dashboard, carriage returns are translated into "<br>" which end up visible to the user (see screen capture attached).
Does this happen when the carriage returns are not adjacent to a URL?
Severity: normal → trivial
Flags: needinfo?(alexis+bugs)
Priority: -- → P4
Yes, it happens whenever there is a line return in a message.
e.g. https://marketplace.firefox.com/comm/thread/33600
Flags: needinfo?(alexis+bugs)
Attached image brrr2.png
Yes it does, see the attachment.
Whiteboard: [ktlo]
Assignee: nobody → ashort
https://github.com/mozilla/commbadge/commit/5612af9bc8968e80c7711a6e41957c60251ee574
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2016-03-29
This was put a wontfix: https://bugzilla.mozilla.org/show_bug.cgi?id=1160984 .
I see here that we talk about the same issue, that is now FIXED. 
I am happy!

Verified as fixed on MP-dev FF47(Win 7).
Postfix screenshot: http://screencast.com/t/2TYRyrvn0Lko
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: