Comments are not escaped properly in the communication dashboard

VERIFIED FIXED in 2016-03-29

Status

Marketplace
Reviewer Tools
P4
trivial
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: alexis, Assigned: ashort)

Tracking

Avenir
2016-03-29
Points:
---

Details

(Whiteboard: [ktlo])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8654795 [details]
brrrrr.png

When submitting new entries in the communication dashboard, carriage returns are translated into "<br>" which end up visible to the user (see screen capture attached).
Does this happen when the carriage returns are not adjacent to a URL?
Severity: normal → trivial
Flags: needinfo?(alexis+bugs)
Priority: -- → P4
Yes, it happens whenever there is a line return in a message.
e.g. https://marketplace.firefox.com/comm/thread/33600
Flags: needinfo?(alexis+bugs)
(Reporter)

Comment 3

2 years ago
Created attachment 8655912 [details]
brrr2.png

Yes it does, see the attachment.

Updated

2 years ago
Whiteboard: [ktlo]

Updated

2 years ago
Assignee: nobody → ashort
(Assignee)

Comment 4

2 years ago
https://github.com/mozilla/commbadge/commit/5612af9bc8968e80c7711a6e41957c60251ee574
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2016-03-29

Comment 5

2 years ago
This was put a wontfix: https://bugzilla.mozilla.org/show_bug.cgi?id=1160984 .
I see here that we talk about the same issue, that is now FIXED. 
I am happy!

Verified as fixed on MP-dev FF47(Win 7).
Postfix screenshot: http://screencast.com/t/2TYRyrvn0Lko
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.