1200226 - Site session data loss

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

https://groups.google.com/a/mozilla.com/d/msgid/ios-mobile-testers/1441010325081.bf65a14f4f46e8%40mozgaia

It isn't clear, a) this only happens when the active session in a tab is closed b) on device idle (like the WKProcessPool reset bug) and c) on sites other than Bugzilla.

Comment 1

[Stephan Leroux [:sleroux]]

For this bug, we'll remove the workaround KVOURL code where we reset the process pool to resolve this issue.

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1030

This patch removes the resetProcessPool call from KVOURL and memory warning callbacks. We'll probably want to see what impact this change has on the white screen issue.

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1029

v1.0 Patch

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8656691 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1030

I'm mildly concerned that we're changing two things at once here, but it's not a bad starting point if you're confident.

Comment 5

[Stephan Leroux [:sleroux]]

I think we should remove the resetting of the content pool from both because I feel like if we don't remove it from the memory callback, the issue might not be resolved in that case.

Comment 6

[Stephan Leroux [:sleroux]]

Any thoughts on this :st3fan?

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I think this is the right thing to do.

Comment 8

[Stephan Leroux [:sleroux]]

Merged