Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aaronmt, Assigned: sleroux)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios1.0.5+, fxios-v1.0 affected)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
https://groups.google.com/a/mozilla.com/d/msgid/ios-mobile-testers/1441010325081.bf65a14f4f46e8%40mozgaia

It isn't clear, a) this only happens when the active session in a tab is closed b) on device idle (like the WKProcessPool reset bug) and c) on sites other than Bugzilla.
(Assignee)

Comment 1

2 years ago
For this bug, we'll remove the workaround KVOURL code where we reset the process pool to resolve this issue.
(Assignee)

Updated

2 years ago
tracking-fxios: ? → 1.0.5+
(Assignee)

Updated

2 years ago
Depends on: 1194726
(Assignee)

Updated

2 years ago
Assignee: nobody → sleroux
(Assignee)

Updated

2 years ago
status-fxios-v1.0: --- → affected
(Assignee)

Comment 2

2 years ago
Created attachment 8656691 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1030

This patch removes the resetProcessPool call from KVOURL and memory warning callbacks. We'll probably want to see what impact this change has on the white screen issue.
Attachment #8656691 - Flags: review?(rnewman)
(Assignee)

Comment 3

2 years ago
Created attachment 8656693 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1029

v1.0 Patch
Attachment #8656693 - Flags: review?(rnewman)
Status: NEW → ASSIGNED
Comment on attachment 8656691 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1030

I'm mildly concerned that we're changing two things at once here, but it's not a bad starting point if you're confident.
Attachment #8656691 - Flags: review?(rnewman) → review+
Attachment #8656693 - Flags: review?(rnewman) → review+
(Assignee)

Comment 5

2 years ago
I think we should remove the resetting of the content pool from both because I feel like if we don't remove it from the memory callback, the issue might not be resolved in that case.
(Assignee)

Comment 6

2 years ago
Any thoughts on this :st3fan?
Flags: needinfo?(sarentz)
I think this is the right thing to do.
Flags: needinfo?(sarentz)
(Assignee)

Comment 8

2 years ago
Merged
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.