1200236 - Tab audio indicator displays incorrect tooltip after move to new window

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[magicp]

Attachment: tab-audio-indicator-tooltip.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150830030224

Steps to reproduce:

1. Run Firefox 42.0a2 or 43.0a1
2. Open new tab (https://www.mozilla.org/en-US/about)
3. Play video in the page
4. Mute the tab
5. Move the tab to new window
6. Confirm the tooltip of muted icon


Actual results:

Tab audio indicator displays incorrect tooltip after move to new window.


Expected results:

Tab audio indicator should be displayed correct tooltip also after move to new window.

Comment 1

[magicp]

Also need twice click for unmute.

Comment 2

[(no longer active)]

Nice find!

Comment 3

[(no longer active)]

What's happening here is that we are setting the muted attribute on the tab, but we're not calling mute() on the browser until mTabProgressListener.onStateChange(), and we look at the audioMuted attribute of the browser to pick what text to show in the tooltip, hence the inconsistency.  We should just mute the browser properly.

Comment 4

[(no longer active)]

Attachment: Mute the browser when swapping a muted tab

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9680bd9d3a6d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9680bd9d3a6d

Comment 7

[(no longer active)]

Comment on attachment 8659601 [details] [diff] [review]
Mute the browser when swapping a muted tab

Approval Request Comment
[Feature/regressing bug #]: Tab audio indicator feature polish
[User impact if declined]: See comment 0.
[Describe test coverage new/current, TreeHerder]: Has a test.
[Risks and why]: Super safe.
[String/UUID change made/needed]: None.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8659601 [details] [diff] [review]
Mute the browser when swapping a muted tab

Polish the new feature, taking it.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/505a069e6018

Comment 10

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on latest Aurora 43.0a2 (buildID: 20151011004016) and on Firefox 42 Beta 5 (buildID: 20151008162217).