Closed Bug 1200236 Opened 4 years ago Closed 4 years ago

Tab audio indicator displays incorrect tooltip after move to new window

Categories

(Firefox :: Tabbed Browser, defect)

43 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 43
Tracking Status
firefox42 --- verified
firefox43 --- verified

People

(Reporter: magicp.jp, Assigned: ehsan)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150830030224

Steps to reproduce:

1. Run Firefox 42.0a2 or 43.0a1
2. Open new tab (https://www.mozilla.org/en-US/about)
3. Play video in the page
4. Mute the tab
5. Move the tab to new window
6. Confirm the tooltip of muted icon


Actual results:

Tab audio indicator displays incorrect tooltip after move to new window.


Expected results:

Tab audio indicator should be displayed correct tooltip also after move to new window.
Component: Untriaged → Tabbed Browser
Also need twice click for unmute.
Blocks: 486262
Nice find!
Assignee: nobody → ehsan
What's happening here is that we are setting the muted attribute on the tab, but we're not calling mute() on the browser until mTabProgressListener.onStateChange(), and we look at the audioMuted attribute of the browser to pick what text to show in the tooltip, hence the inconsistency.  We should just mute the browser properly.
Attachment #8659601 - Flags: review?(jaws)
Attachment #8659601 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/9680bd9d3a6d
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment on attachment 8659601 [details] [diff] [review]
Mute the browser when swapping a muted tab

Approval Request Comment
[Feature/regressing bug #]: Tab audio indicator feature polish
[User impact if declined]: See comment 0.
[Describe test coverage new/current, TreeHerder]: Has a test.
[Risks and why]: Super safe.
[String/UUID change made/needed]: None.
Attachment #8659601 - Flags: approval-mozilla-aurora?
Comment on attachment 8659601 [details] [diff] [review]
Mute the browser when swapping a muted tab

Polish the new feature, taking it.
Attachment #8659601 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
See Also: → 1211314
Verified fixed on latest Aurora 43.0a2 (buildID: 20151011004016) and on Firefox 42 Beta 5 (buildID: 20151008162217).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.