1200252 - Add marker for when the IPC request for a composite is sent to the compositor thread

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8659242 [details] [diff] [review]
v1

Review of attachment 8659242 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for js/css changes

::: browser/devtools/performance/modules/markers.js
@@ +79,5 @@
>      label: L10N.getStr("marker.label.composite"),
>    },
> +  "CompositeForwardTransaction": {
> +    group: 0,
> +    colorName: "graphs-bluegrey",

Should also be green, no? I guess ultimately these will be rolled into their own "frame" marker though

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> Comment on attachment 8659242 [details] [diff] [review]
> v1
> 
> Review of attachment 8659242 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ for js/css changes
> 
> ::: browser/devtools/performance/modules/markers.js
> @@ +79,5 @@
> >      label: L10N.getStr("marker.label.composite"),
> >    },
> > +  "CompositeForwardTransaction": {
> > +    group: 0,
> > +    colorName: "graphs-bluegrey",
> 
> Should also be green, no? I guess ultimately these will be rolled into their
> own "frame" marker though

Don't think so. That's why I added bluegrey – this operation isn't a composite per se, it's a composite request. Different.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d598f1792a94

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d598f1792a94