Add marker for when the IPC request for a composite is sent to the compositor thread

RESOLVED FIXED in Firefox 43

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: vporof, Assigned: vporof)

Tracking

(Blocks 1 bug)

unspecified
Firefox 43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

No description provided.
Blocks: perf-gaming
No longer depends on: perf-gaming
Posted patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8659242 - Flags: review?(matt.woodrow)
Attachment #8659242 - Flags: review?(jsantell)
Attachment #8659242 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8659242 [details] [diff] [review]
v1

Review of attachment 8659242 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for js/css changes

::: browser/devtools/performance/modules/markers.js
@@ +79,5 @@
>      label: L10N.getStr("marker.label.composite"),
>    },
> +  "CompositeForwardTransaction": {
> +    group: 0,
> +    colorName: "graphs-bluegrey",

Should also be green, no? I guess ultimately these will be rolled into their own "frame" marker though
Attachment #8659242 - Flags: review?(jsantell) → review+
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> Comment on attachment 8659242 [details] [diff] [review]
> v1
> 
> Review of attachment 8659242 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ for js/css changes
> 
> ::: browser/devtools/performance/modules/markers.js
> @@ +79,5 @@
> >      label: L10N.getStr("marker.label.composite"),
> >    },
> > +  "CompositeForwardTransaction": {
> > +    group: 0,
> > +    colorName: "graphs-bluegrey",
> 
> Should also be green, no? I guess ultimately these will be rolled into their
> own "frame" marker though

Don't think so. That's why I added bluegrey – this operation isn't a composite per se, it's a composite request. Different.
https://hg.mozilla.org/mozilla-central/rev/d598f1792a94
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.