1200303 - DOMMetaChanged events should trigger recomputation of ZoomConstraintsClient

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Bug 976616 added some code so that changes to an existing meta-viewport element triggered a recomputation of the CSS viewport. The ZoomConstraints need to be recomputed similarly.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Pretty simple patch, I just overlooked this when reviewing your patch or I would have asked you to incorporate it into yours. For now this only affects the minimum-scale, maximum-scale, and user-scalable properties on B2G (i.e. changes to those properties on the existing meta tag don't get reflected without this fix).

Comment 2

[Mike Taylor [:miketaylr]]

Comment on attachment 8655055 [details] [diff] [review]
Patch

Review of attachment 8655055 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for catching this! I can update the tests tomorrow so we don't accidentally break this in the future.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I don't know if this can easily be covered by tests. The existing tests all use DOMWindowUtils.getViewportInfo to get the viewport info to test, but that's path doesn't exercise this ZoomConstraintsClient code.

Comment 4

[Mike Taylor [:miketaylr]]

Ah, gotcha.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bccb519d4c08

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bccb519d4c08