Closed Bug 1200303 Opened 6 years ago Closed 6 years ago

DOMMetaChanged events should trigger recomputation of ZoomConstraintsClient

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Bug 976616 added some code so that changes to an existing meta-viewport element triggered a recomputation of the CSS viewport. The ZoomConstraints need to be recomputed similarly.
Attached patch PatchSplinter Review
Pretty simple patch, I just overlooked this when reviewing your patch or I would have asked you to incorporate it into yours. For now this only affects the minimum-scale, maximum-scale, and user-scalable properties on B2G (i.e. changes to those properties on the existing meta tag don't get reflected without this fix).
Attachment #8655055 - Flags: review?(miket)
Comment on attachment 8655055 [details] [diff] [review]
Patch

Review of attachment 8655055 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for catching this! I can update the tests tomorrow so we don't accidentally break this in the future.
Attachment #8655055 - Flags: review?(miket) → review+
I don't know if this can easily be covered by tests. The existing tests all use DOMWindowUtils.getViewportInfo to get the viewport info to test, but that's path doesn't exercise this ZoomConstraintsClient code.
Ah, gotcha.
https://hg.mozilla.org/mozilla-central/rev/bccb519d4c08
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.