FxOS Geo Stumbling: refactor for independance of GonkGPS code

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: garvan, Unassigned)

Tracking

unspecified
mozilla43
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

Addressing item 1 from bug 1199093, refactor the code so that it isn't dependant on GonkGPSGeolocationProvider, and can be called from the DOM geo code at a higher layer.

There are 2 reasons to do this:
1) cleaner code separation
2) so it can be called from the higher layer code that is not replaced by Qualcomm

+++ This bug was initially created as a clone of Bug #1199093 +++
This is follow-up bug for FxOS Geo Stumbling.
In this bug, we would like to complete the following items.
1. Refactoring to a high layer. (a function such as nsGeolocationService::geostumble(nsGeoPosition))
2. Upload Stumble as gzip format
3. Creating an XPCOM component to replace most of UploadStumbleRunnable::Run
Refactors the code to have a single entry point, the function:
void MozStumble(position);

The only call in GonkGPS code is the call to MozStumble(position);
Attachment #8654963 - Flags: review?(josh)
Comment on attachment 8654963 [details] [diff] [review]
remove-code-from-gonkgps.diff

Review of attachment 8654963 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/GeolocationUtil.cpp
@@ +1,2 @@
> +/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> +/* Copyright 2012 Mozilla Foundation and Mozilla contributors

This is not the MPL v2.

::: dom/system/gonk/GeolocationUtil.h
@@ +1,2 @@
> +/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> +/* Copyright 2012 Mozilla Foundation and Mozilla contributors

Not the MPL v2.
Attachment #8654963 - Flags: review?(josh) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9838257c96b139b41678757f0ec118b74f9f174f
Bug 1200304 - Move stumbling code from gonkgps to MozStumbler.cpp. r=jdm
https://hg.mozilla.org/mozilla-central/rev/9838257c96b1
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.