120034 - GTK MozEmbed widget needs gtk_moz_embed_single_get_type

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Mark Crichton]

For GTK language bindings, a _get_type function is pretty much required.  However, the mozembed widget is missing one for the GtkMozEmbedSingle class.  Don't have a patch, but the code will be highly similar to the current gtk_moz_embed_get_type function.



Also, proper type checking macros should be setup.  Again, similar to the GtkMozEmbed macros.

Comment 1

[Mark Crichton]

Ok, this one appears fixed in the trunk of CVS.  Is it really, Chris?

Comment 2

[Christopher Blizzard (:blizzard)]

Uhh...I don't think so?

Comment 3

[Mark Crichton]

http://lxr.mozilla.org/seamonkey/source/embedding/browser/gtk/src/gtkmozembed2.cpp#1151

Then what's that? :)

I think that the function declaration is missing in the header file,
however.

Comment 4

[Mark Crichton]

Attachment: Patch to add GET_TYPE infor for single_embed

The C code is there, it just needs to be exported.  This is mostly to keep
GTK+ language bindings happy.

Comment 5

[Andrew Hagen]

Sounds important. Confirming.

Comment 6

[Vedran Miletic]

retargeting

Comment 7

[Torsten Schoenfeld]

Mark posted a fine patch two and a half years ago.  It was even confirmed. 
What's preventing it from going in?

Comment 8

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: updated to current trunk

This is the above patch, updated to apply cleanly to the current trunk.

Asking for r/sr.

Comment 9

[Marco Pesenti Gritti]

Comment on attachment 169120 [details] [diff] [review]
updated to current trunk

It looks good to me. I dont know if there was a reason to keep this private
though. Anyway Blizzard has sr so he can address it.

Comment 10

[Christopher Blizzard (:blizzard)]

Comment on attachment 169120 [details] [diff] [review]
updated to current trunk

This will still work with gtk 1.2, right?

Comment 11

[Christian Persch (GNOME) (away; not receiving bug mail)]

Yes, I just successfully compiled a gtk-1.2 build with this patch.

Comment 12

[Marco Pesenti Gritti]

checked in on the trunk