Closed Bug 1200360 Opened 6 years ago Closed 6 years ago
Fix the $(DEFINES) in HOST
_CFLAGS in modules/libmar/tool/moz .build
40 bytes, text/x-review-board-request
In bug 1198226 I moved HOST_CFLAGS into moz.build. Unfortunately modules/libmar/tool/Makefile.in had `HOST_CFLAGS += $(DEFINES)`, which wound up translating to `HOST_CFLAGS += ['$(DEFINES)'] in moz.build, which is not fantastic. We shouldn't have to reference make variables in moz.build. There's no good way to make this work as written right now, but odds are the code in this directory only really wants a couple of things from DEFINES, so we could probably just cherry pick those and put them in moz.build instead.
bug 1200360 - fix $(DEFINES) usage in modules/libmar/tool/moz.build. r?mshal
Attachment #8658279 - Flags: review?(mshal)
This turns out to not be that bad at all, especially after adding HOST_DEFINES in bug 1198226.
Comment on attachment 8658279 [details] MozReview Request: bug 1200360 - fix $(DEFINES) usage in modules/libmar/tool/moz.build. r?mshal https://reviewboard.mozilla.org/r/18519/#review16581
Attachment #8658279 - Flags: review?(mshal) → review+
You need to log in before you can comment on or make changes to this bug.