1200360 - Fix the $(DEFINES) in HOST_CFLAGS in modules/libmar/tool/moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

In bug 1198226 I moved HOST_CFLAGS into moz.build. Unfortunately modules/libmar/tool/Makefile.in had `HOST_CFLAGS += $(DEFINES)`, which wound up translating to `HOST_CFLAGS += ['$(DEFINES)'] in moz.build, which is not fantastic. We shouldn't have to reference make variables in moz.build. There's no good way to make this work as written right now, but odds are the code in this directory only really wants a couple of things from DEFINES, so we could probably just cherry pick those and put them in moz.build instead.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1200360 - fix $(DEFINES) usage in modules/libmar/tool/moz.build. r?mshal

bug 1200360 - fix $(DEFINES) usage in modules/libmar/tool/moz.build. r?mshal

Comment 2

[(not currently active) Ted Mielczarek]

This turns out to not be that bad at all, especially after adding HOST_DEFINES in bug 1198226.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8658279 [details]
MozReview Request: bug 1200360 - fix $(DEFINES) usage in modules/libmar/tool/moz.build. r?mshal

https://reviewboard.mozilla.org/r/18519/#review16581

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a18a6dca709b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a18a6dca709b