Fix the $(DEFINES) in HOST_CFLAGS in modules/libmar/tool/moz.build

RESOLVED FIXED in Firefox 43

Status

RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: ted, Unassigned)

Tracking

Trunk
mozilla43

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

In bug 1198226 I moved HOST_CFLAGS into moz.build. Unfortunately modules/libmar/tool/Makefile.in had `HOST_CFLAGS += $(DEFINES)`, which wound up translating to `HOST_CFLAGS += ['$(DEFINES)'] in moz.build, which is not fantastic. We shouldn't have to reference make variables in moz.build. There's no good way to make this work as written right now, but odds are the code in this directory only really wants a couple of things from DEFINES, so we could probably just cherry pick those and put them in moz.build instead.
Created attachment 8658279 [details]
MozReview Request: bug 1200360 - fix $(DEFINES) usage in modules/libmar/tool/moz.build. r?mshal

bug 1200360 - fix $(DEFINES) usage in modules/libmar/tool/moz.build. r?mshal
Attachment #8658279 - Flags: review?(mshal)
This turns out to not be that bad at all, especially after adding HOST_DEFINES in bug 1198226.
Comment on attachment 8658279 [details]
MozReview Request: bug 1200360 - fix $(DEFINES) usage in modules/libmar/tool/moz.build. r?mshal

https://reviewboard.mozilla.org/r/18519/#review16581
Attachment #8658279 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/a18a6dca709b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

Updated

11 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.