120041 - page load tests timing out on four pages as of ~10pm 01/14 (win2k/linux)

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[John Morrison]

The page load test is now timing out for four pages, as of builds pulled after 
~10pm this evening. The pages that are timing out are www.yahoo.com, 
www.msn.com, www.voodooextreme.com, www.tomshardware.com on either the test 
server http://cowtools/ or on the btek test. 

I have the same timeout problem on every load of those pages also on win2k, in 
a brand new build that I updated at the same time (about 10pm). 

I figure this is you, pav, with the changes to prevent redundant reload of 
images from the network (thanks for fixing that, by the way. Sorry about this
glitch). It would be good to get a fix for this asap, among other reasons being 
that this timeout will add another 10 min. to the btek cycle, and we narrow the 
coverage of an already too narrow test.

Comment 1

[Stuart Parmenter]

Attachment: typo

a last-minute change I made for darin to QI to caching chan instead of http
chan used the wrong param.

Comment 2

[Darin Fisher]

sr=darin

Comment 3

[Stuart Parmenter]

Attachment: fix

ok, the problem was that we weren't calling the proxy's OnStopRequest when the
proxy was removed if it hadn't been sent.  imgRequestProxy::OnStopRequest
removes itself from the loadgroup, so not calling this would leave the request
in there forever.

Comment 4

[Darin Fisher]

if it works, ship it!  rs=darin

Comment 5

[timeless]

Comment on attachment 65182 [details] [diff] [review]
fix

[rs=darin]
r=timeless

Comment 6

[Stuart Parmenter]

fixed

Comment 7

[Terri Preston]

Verified Fixed win XP build 2002011604