MarionetteBaseTestRunner defaults startup_timeout to None, should be seconds

RESOLVED FIXED in Firefox 43

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: erahm, Assigned: jgriffin)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

MarionetteBaseTestRunner defaults startup_timeout to 'None', this cascades down [1] and overrides the default transport timeout in the Marionette class of '60' [2] which causes an exception:

> Traceback (most recent call last):
>   File "/home/erahm/dev/areweslimyet/benchtester/MarionetteTest.py", line 111, in run_test
>     runner.run_tests([ testpath ])
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette/runner/base.py", line 724, in run_tests
>     self.start_marionette()
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette/runner/base.py", line 669, in start_marionette
>     self.marionette = self.driverclass(**self._build_kwargs())
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 591, in __init__
>     assert(self.wait_for_port(timeout=startup_timeout)), "Timed out waiting for port!"
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 667, in wait_for_port
>     timeout=timeout)
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette_transport/transport.py", line 122, in wait_for_port
>     while datetime.datetime.now() - starttime < datetime.timedelta(seconds=timeout):
> TypeError: unsupported type for timedelta seconds component: NoneType

[1] https://dxr.mozilla.org/mozilla-central/rev/f2518b8a7b97b5bb477e94bc9131584007aac887/testing/marionette/client/marionette/runner/base.py#474,520,620
[2] https://dxr.mozilla.org/mozilla-central/rev/f2518b8a7b97b5bb477e94bc9131584007aac887/testing/marionette/driver/marionette_driver/marionette.py#540,591
(Assignee)

Updated

3 years ago
Assignee: nobody → jgriffin
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8655092 [details]
MozReview Request: Bug 1200420 - Better handling of startup_timeout, r=AutomatedTester

Bug 1200420 - Better handling of startup_timeout, r=AutomatedTester
Attachment #8655092 - Flags: review?(dburns)
Attachment #8655092 - Flags: review?(dburns) → review+
Comment on attachment 8655092 [details]
MozReview Request: Bug 1200420 - Better handling of startup_timeout, r=AutomatedTester

https://reviewboard.mozilla.org/r/17819/#review16303
https://hg.mozilla.org/mozilla-central/rev/f899c037047e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.