1200426 - Convert PROCESS_OBJECT event to native call

Status: RESOLVED FIXED

(Core :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

PROCESS_OBJECT event in GeckoEvent is used to set the GeckoLayerClient object in Gecko. We can convert it to a native call in GeckoView.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Allow specifying parameter type when queuing native calls (v1)

When we queue native calls in GeckoThread, we try to deduce the
types of the arguments through Object.getClass(). However, there are
cases where this could fail. For example, the argument could be null,
or could be a String instance but the parameter type is really
CharSequence.

This patch introduces a way to optionally include parameter types for
the queued call. When a passed-in argument is a Class instance, it is
treated as the type for the next queued parameter, and the next argument
is treated as the value for the queued parameter. For example,

> // Queue a call with CharSequence parameter, using a String argument.
> GeckoThread.queueNativeCall(..., CharSequence.class, "123");

> // Queue a call with String parameter, using a null argument.
> GeckoThread.queueNativeCall(..., String.class, null);

Deduction is still performed when the type is missing:

> // Queue a call with int, String, and boolean parameter.
> GeckoThread.queueNativeCall(..., 42, "123", true);

> // Queue the same call but with a null argument.
> GeckoThread.queueNativeCall(..., 42, String.class, null, true);

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Convert PROCESS_OBJECT GeckoEvent to native call (v1)

The PROCESS_OBJECT GeckoEvent is used to set the layer client object in
Gecko once Gecko is done loading. This patch converts it to a native
call in GeckoView.Window.

Because the native method has an Object parameter, we need the first patch
in order to queue a call to it using GeckoThread.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2dea192c7f33
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dcc2fb45208

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for tpn bustage:
https://treeherder.mozilla.org/logviewer.html#?job_id=15307384&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/f698df326e81

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6dbb76e6a3a4
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e8206d7352e

Comment 6

[Carsten Book [:Tomcat]]

sorry had to back this out since this or the other checkin caused https://treeherder.mozilla.org/logviewer.html#?job_id=15360927&repo=mozilla-inbound

Comment 7

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a29c00eefd15
https://hg.mozilla.org/integration/mozilla-inbound/rev/600b7550c0ca

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ca3465da606
https://hg.mozilla.org/integration/mozilla-inbound/rev/dee668cc4bb8

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ca3465da606
https://hg.mozilla.org/mozilla-central/rev/dee668cc4bb8