1200427 - tc-base: base.Entity support for signed entities

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

We should have a feature to HMAC sign entities store in azure table storage.
That way injection in azure won't compromise us.

This reduces attack vectors.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: Github PR for base

Hi, take a look at this...
Adding a signature to all entities such that gaining access to our azure account you can delete stuff, but you won't be able to fake entities.
Hence, an attacker will be forced to compromise our heroku app, the reduces our attack surface.

For auth, I will encrypt the accessToken, but also sign the entity so someone with access to azure can't insert extra scopes with the secret key (given to taskcluster-auth through env var).

Comment 2

[Anthony Miyaguchi [:amiyaguchi]]

Comment on attachment 8655090 [details] [review]
Github PR for base

Looks good to me, the code is straightforward and the tests seem to cover all the common use-cases.

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

merged... thanks for the quick review...