Closed Bug 1200458 Opened 6 years ago Closed 6 years ago

Skip permission check for .hgrc on Windows in hgsetup wizard

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

On Windows the value returned by os.stat just doesn't make much sense. We should just skip the checking step.

For safety, we probably could check whether the file is in NTFS and whether this file is encrypted, but it seems to be a bit complicated without third-party Python package, so isn't worth that to me.
Bug 1200458 - Skip permission check for .hgrc on Windows in hgsetup wizard.
Attachment #8655149 - Flags: review?(gps)
Comment on attachment 8655149 [details]
MozReview Request: Bug 1200458 - Skip permission check for .hgrc on Windows in hgsetup wizard.

https://reviewboard.mozilla.org/r/17845/#review15921
Attachment #8655149 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/f05b06b50a39
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.