1200461 - hgsetup should check and ask for Bugzilla apikey instead of password

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+11]

The extension reviewboard currently relies on Bugzilla apikey, and we should also make bzpost use that (bug 1200449). Thus we should replace the prompt for password with that for apikey.

Also it'd probably be better to check that the user is not using the old settings in addition, because they are not safe.

Comment 1

[Gregory Szorc [:gps]]

A good first step would be to rip out the prompt for the password. We can add API key prompting back later. This is a bit sub-optimal, but pushing to MozReview will print a nice error message with instructions if API keys aren't being used. So it's not the end of the world.

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1200461 - Prompt for Bugzilla API Key instead of password; r?smacleod

Bug 1200461 - Prompt for Bugzilla API Key instead of password; r?smacleod

All extensions in version-control-tools should support Bugzilla API Keys
now. MozReview requires them. We'll likely remove support for passwords
and cookie auth in the future. This commit transitions the Mercurial
setup wizard to API Keys exclusively.

Comment 4

[Steven MacLeod [:smacleod]]

Comment on attachment 8657376 [details]
MozReview Request: Bug 1200461 - Prompt for Bugzilla API Key instead of password; r?smacleod

https://reviewboard.mozilla.org/r/18371/#review17043

::: tools/mercurial/hgsetup/wizard.py:406
(Diff revision 1)
> +            if bzpass or bzuserid or bzcookie:
> +                print(LEGACY_BUGZILLA_CREDENTIALS_DETECTED)
> +                c.clear_legacy_bugzilla_credentials()

I don't think we should be so aggressive to just remove the old credentials without prompting (especially since they're techincally supported still).

How about we deploy this with a prompt to remove the credentials (or, remove them if we verify you *do* have the api key).

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c23f4fdd401da0ecec553b40ffdd49bde106548
Bug 1200461 - Prompt for Bugzilla API Key instead of password; r=smacleod

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9c23f4fdd401