1200583 - [Messages][Tests] It's difficult to debug when we forget to set the mock data in an integration test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

Currently, API mocks wait that we set the mock data before returning anything, which is a good thing.

As a result when we forget to set the mock data, they never return. It's quite difficult to debug.

Maybe a good enough solution is to output a console.log message the first time we call getStorage.

Comment 1

[Oleg Zasypkin [:azasypkin]]

I think, I have one idea that I'd like to try that should make our code working with mocks much easier (from test writer POV).

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1200583-test-storage > mozilla-b2g:master

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8684890 [details] [review]
[gaia] azasypkin:bug-1200583-test-storage > mozilla-b2g:master

Hey Julien,

How does it look?

If you're OK with it, I'd say it will be better to uplift this to v2.5 so that test infrastructure is similar to master + without this I can't create test for bug 1217859.

Thanks!

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8684890 [details] [review]
[gaia] azasypkin:bug-1200583-test-storage > mozilla-b2g:master

r=me but with some food for thoughts on the PR. I'd like that you at least ask yourself about these questions, but maybe we can look at it later.

Comment 5

[Oleg Zasypkin [:azasypkin]]

Thanks for review and questions! I've replied at GitHub and filed a bug 1223350 to investigate some oddness further.

Treeherder is green, so landed: https://github.com/mozilla-b2g/gaia/commit/4b7779a91f7bd3c57c7ff1ada1f03a6a8b0bc5ec

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8684890 [details] [review]
[gaia] azasypkin:bug-1200583-test-storage > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): n/a
[User impact] if declined: no user impact, but it will be quite hard to uplift other fixes with integration tests to v2.5 branch without this patch.
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): no risk, test-only change.
[String changes made]: n/a

Comment 7

[Mahendra Potharaju [:mahe]]

Comment on attachment 8684890 [details] [review]
[gaia] azasypkin:bug-1200583-test-storage > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 8

[Carsten Book [:Tomcat]]

laned in 2.5 https://github.com/mozilla-b2g/gaia/commit/91e1047a80f1207c2af924a38f292141c647a250