1200605 - include (b|y)-2008 spot instances in slave health

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Update http://hg.mozilla.org/build/slave_health/ to include the new b and y 2008 spot instances.

Comment 1

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: html reindentation

This is just a clean-up commit to indent html.

Comment 2

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: link terminators

Another cleanup commit to terminate links.

Comment 3

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: more link terminators

more cleanup

Comment 4

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: add (b|y)-2008 spot instances

This commit actually adds the required changes for b & y 2008 spot

Comment 5

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: html reindentation

whitespace changes ignored. (hg diff --ignore-space-change)

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8655437 [details] [diff] [review]
html reindentation

Review of attachment 8655437 [details] [diff] [review]:
-----------------------------------------------------------------

even this 'ignore whitespace' version is daunting to look at, but, my only issue is a nitpick...

::: jacuzzis.html
@@ +305,5 @@
>                var dry_states = states; // dry meaning not in a jacuzzi
>                var dry_jacuzzi_excludes = [];
> +                  $.each(jacuzzi_slaves, function(slavename) {
> +                    if (jacuzzi_slaves[slavename].startsWith(slavetype)) {
> +                      if ((jacuzzi_slaves[slavename] in all_slaves_data) && (all_slaves_data[jacuzzi_slaves[slavename]]["slave_class"] == slaveclass)) {

I'd rather THIS if line stay split across two lines as it was ;-)

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8655429 [details] [diff] [review]
link terminators

>         <tr id="b-2008-ix">
>-          <td class="slavetype"><a href="./slavetype.html?class=build&type=b-2008-ix">b-2008-ix</td>
>-          <td rowspan="2" class="pending">0<td class="status"></td>
>+          <td class="slavetype"><a href="./slavetype.html?class=build&type=b-2008-ix">b-2008-ix</a></td>
>+          <td rowspan="3" class="pending">0</td>
>+          <td class="status"></td>

That pending rowspan seems to have leaked into this patch

r+ with that fixed

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 8655434 [details] [diff] [review]
add (b|y)-2008 spot instances

Review of attachment 8655434 [details] [diff] [review]:
-----------------------------------------------------------------

::: index.html
@@ +116,5 @@
>          </tr>
> +        <tr id="b-2008-spot">
> +          <td class="slavetype"><a href="./slavetype.html?class=build&type=b-2008-spot">b-2008-spot</a></td>
> +          <td class="status"></td>
> +        </tr>

if you drop rowspan from previous patch, needs to be added back here :-)

Comment 9

[Rob Thijssen [:grenade (EET/UTC+0300)]]

squashed commits into one for push: https://hg.mozilla.org/build/slave_health/rev/1a542b508eeb