Closed Bug 1200621 Opened 10 years ago Closed 10 years ago

Basic Search Engines should not be auto-flagged when sources are added

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Product:
addons.mozilla.org Graveyard
Component:
Admin/Editor Tools
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2015-09-17

People

(Reporter: erosman, Assigned: magopian)

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0 Build ID: 20150826023504 Steps to reproduce: Basic Search Engines (ie single xml file) should not be auto-flagged when sources are added (needlessly by the developer) Example: https://addons.mozilla.org/en-US/editors/review/livingxworlddotcom
We should probably do the same for other non-extensions like dictionaries and language packs.
Status: UNCONFIRMED → NEW
Ever confirmed: true
:jorgev would it make sense to restrict the flagging only to extensions then?
Flags: needinfo?(jorge)
PR: https://github.com/mozilla/olympia/pull/728 :jorgev this PR only flags for admin review if the source are attached to an extension or a plugin, please let me know if you want something else.
Assignee: nobody → mathieu
We don't host plugins, so that's not necessary. If ADDON_API refers to extensions using WebExtensions or the SDK, then it should be included as well.
Flags: needinfo?(jorge)
As discussed on IRC, ADDON_API also seems legacy (as for ADDON_PLUGIN), so we only need to flag for ADDON_EXTENSION. Updated the PR.
Commits pushed to master at https://github.com/mozilla/olympia https://github.com/mozilla/olympia/commit/f7ef88f3c41fb465f64634832b89af0db78534d8 Don't flag for admin review when source submitted if not needed (bug 1200621) https://github.com/mozilla/olympia/commit/528ed7b8dca238b40b5912f8a5432b9acf385bc9 Merge pull request #728 from magopian/1200621-dont-flag-non-extensions-when-sources-submitted Don't flag for admin review when source submitted if not needed (bug 1200621)
STR: 1/ submit a search tool, with attached sources 2/ go to the reviewers tools, and make sure it's not flagged as "admin review"
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-09-17
Verified as fixed in FF40(Win7) in addons.allizom.org After submission the search engine does not have a admin review flag: http://screencast.com/t/b296CtaLrX Closing bug.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.