1200663 - [Raptor] Port regression detection code to nodejs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[Robert Wood [:rwood]]

Port the regression detection code from python (https://github.com/eliperelman/phanalysis.git) to one or more nodejs npm packages.

* Update accordingly for the new @mozilla/raptor v2.0 / influx 0.9 data format
* Don't consume clients or query data directly; raptor or another module will worry about getting data to this module
* Port only what we currently use ie. analyze_raptor.py and dependencies

Comment 1

[Robert Wood [:rwood]]

Attachment: https://github.com/rwood-moz/raptor-regression/pull/1

Comment 2

[:Eli Perelman]

Comment on attachment 8657474 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/1

Comments on GH.

Comment 3

[Robert Wood [:rwood]]

Comment on attachment 8657474 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/1

Thanks for the thorough review, Eli! PR updated.

Comment 4

[:Eli Perelman]

Comment on attachment 8657474 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/1

Pretty close, I think we're almost done! Just some more comments on GH.

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8657474 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/1

Thanks! PR updated. I know we discussed breaking some of this out into another NPM package for the actual math; I think we should just leave it for now and I'll test it out, and use it for our 2.0 update... then I can always split it out another time, if you're ok with that.

Comment 6

[:Eli Perelman]

Comment on attachment 8657474 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/1

w00t!

Comment 7

[Robert Wood [:rwood]]

Attachment: https://github.com/rwood-moz/raptor-regression/pull/2

Update for newest data input format (query is included in comments). Now the data coming in is already aggregated (before I was expecting all individual points, by mistake). Also the input data is now for a specific context already so no need to pass in app context and entrypoint.

Still needs work like retrieving the actual gaia and gecko version from the revisionId; the annotation info is included in the input data but has to parsed etc. Also needs to be tested with simulated regression data. A good start anyway.

Comment 8

[:Eli Perelman]

Comment on attachment 8661561 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/2

Just a couple comments, r+.