[Raptor] Port regression detection code to nodejs

RESOLVED FIXED

Status

Firefox OS
Gaia::PerformanceTest
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Port the regression detection code from python (https://github.com/eliperelman/phanalysis.git) to one or more nodejs npm packages.

* Update accordingly for the new @mozilla/raptor v2.0 / influx 0.9 data format
* Don't consume clients or query data directly; raptor or another module will worry about getting data to this module
* Port only what we currently use ie. analyze_raptor.py and dependencies
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Comment on attachment 8657474 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/1

Thanks for the thorough review, Eli! PR updated.
Attachment #8657474 - Flags: review?(eperelman)

Comment 4

3 years ago
Comment on attachment 8657474 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/1

Pretty close, I think we're almost done! Just some more comments on GH.
Attachment #8657474 - Flags: review?(eperelman)
(Assignee)

Comment 5

3 years ago
Comment on attachment 8657474 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/1

Thanks! PR updated. I know we discussed breaking some of this out into another NPM package for the actual math; I think we should just leave it for now and I'll test it out, and use it for our 2.0 update... then I can always split it out another time, if you're ok with that.
Attachment #8657474 - Flags: review?(eperelman)
(Assignee)

Comment 7

3 years ago
Created attachment 8661561 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/2

Update for newest data input format (query is included in comments). Now the data coming in is already aggregated (before I was expecting all individual points, by mistake). Also the input data is now for a specific context already so no need to pass in app context and entrypoint.

Still needs work like retrieving the actual gaia and gecko version from the revisionId; the annotation info is included in the input data but has to parsed etc. Also needs to be tested with simulated regression data. A good start anyway.
Attachment #8657474 - Attachment is obsolete: true
Attachment #8661561 - Flags: review?(eperelman)

Comment 8

3 years ago
Comment on attachment 8661561 [details] [review]
https://github.com/rwood-moz/raptor-regression/pull/2

Just a couple comments, r+.
Attachment #8661561 - Flags: review?(eperelman) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.