1200666 - Units for nsDocumentViewer::GetContentSize unclear

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

It seems like the return value of nsDocumentViewer::GetContentSize is off by a factor of 2 on my HiDPI display. I want to use the result to set the size of a containing <browser> element. How should I be doing this? I'm writing JS code.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

As far as I can tell nsDocumentViewer::GetContentSize is returning LayoutDevicePixels (which includes adjustment for both full-zoom and DPI) but it sounds like you want to unapply the DPI adjustment.

Can you assume a full-zoom value of 1.0? If so you can use window.devicePixelRatio to isolate the DPI. Otherwise you probably need to expose nsIWidget::GetDefaultScale() to JS somehow. Alternatively you can add another method to nsDocumentViewer which returns it in the units you want.

Also, I'm assuming this is not Retina mac because if it is there's some BackingScaleFactor() stuff you need to deal with and TBH I don't understand how that works.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Yes, I think I can assume a full-zoom of 1.0. window.devicePixelRatio does the trick.

I'm not on a Retina Mac. I'll make sure to test there though.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Thanks.