Closed
Bug 1200689
Opened 9 years ago
Closed 9 years ago
Style the "Share your tabs/other windows" menu to be consistent with the gear icon menu style
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox43 fixed)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: RT, Assigned: crafuse)
References
Details
(Whiteboard: [visual refresh])
User Story
Apply the same styles to the "Share your tabs/other windows" menu as what is currently implemented for the gear icon menu in the conversation window. Acceptance criteria: * shared tabs menu looks like the gear icon menu (font, spacing, etc) Technical checklist: * review the DOM and CSS structures of both menus * migrate the shared tabs menu to use the gear icon menu CSS * if otherwise unused, remove old shared tabs menu CSS
Attachments
(3 files, 1 obsolete file)
125.31 KB,
image/png
|
Details | |
36.43 KB,
image/png
|
sevaan
:
ui-review+
|
Details |
8.77 KB,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•9 years ago
|
Rank: 18
Priority: -- → P1
Whiteboard: [visual refresh]
Reporter | ||
Comment 1•9 years ago
|
||
Reporter | ||
Updated•9 years ago
|
User Story: (updated)
Updated•9 years ago
|
Points: --- → 2
Comment 2•9 years ago
|
||
grab Dan or Mark when picking up for technical checklist to create....
Points: 2 → 3
Updated•9 years ago
|
User Story: (updated)
Assignee | ||
Comment 3•9 years ago
|
||
Share screen menu styled similar to settings menu.
Attachment #8662114 -
Flags: ui-review?(sfranks)
Updated•9 years ago
|
Attachment #8662114 -
Flags: ui-review?(sfranks) → ui-review+
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → chris.rafuse
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8662426 [details] [diff] [review] Style 'Share tabs/other windows' menu consistently with the gear icon menu Reused and combined settings-menu drop down menu and items CSS for share-screen-menu classes and standardization.
Attachment #8662426 -
Flags: review?(dmose)
Comment 6•9 years ago
|
||
Comment on attachment 8662426 [details] [diff] [review] Style 'Share tabs/other windows' menu consistently with the gear icon menu Review of attachment 8662426 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/loop/content/shared/css/conversation.css @@ +464,5 @@ > +} > + > +.screen-share-menu.dropdown-menu { > + right: 40px; > +} A comment about where this 40px number (and the next one) come from would be helpful, please add one.
Attachment #8662426 -
Flags: review?(dmose) → feedback+
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8662687 [details] [diff] [review] Style 'Share tabs/other windows' menu consistently with the gear icon menu Added comments
Attachment #8662687 -
Flags: review?(dmose)
Assignee | ||
Updated•9 years ago
|
Attachment #8662426 -
Attachment is obsolete: true
Comment 9•9 years ago
|
||
Comment on attachment 8662687 [details] [diff] [review] Style 'Share tabs/other windows' menu consistently with the gear icon menu Review of attachment 8662687 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=dmose
Attachment #8662687 -
Flags: review?(dmose) → review+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a8da1f2d5bfe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•9 years ago
|
Iteration: --- → 43.2 - Sep 7
You need to log in
before you can comment on or make changes to this bug.
Description
•