Closed Bug 1200776 Opened 7 years ago Closed 7 years ago

[Music][NGA] Overlays never appear on b2g-desktop

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S6 (04Sep)

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

Attachments

(1 file)

[gaia] justindarc:bug1200776 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
hub
: review+
Details | Review 
Music NGA is not showing the overlays on b2g-desktop. Its possible this is due to a race condition where the DB is triggering events *before* the listeners are attached. Regardless, an additional check should be added to query the DB status at startup to determine if any overlays need to be displayed.
Blocks: 1196438
I wonder if that's not the same reason as for bug 1198677
Assignee: nobody → jdarcangelo
Comment on attachment 8655644 [details] [review]
[gaia] justindarc:bug1200776 > mozilla-b2g:master

Hub: This should fix the issue. We now explicitly request DB status during startup just in case we missed the window of opportunity for the events.
Attachment #8655644 - Flags: review?(hub)
Comment on attachment 8655644 [details] [review]
[gaia] justindarc:bug1200776 > mozilla-b2g:master

Works great with my activity tests....
Attachment #8655644 - Flags: review?(hub) → review+
Added an important comment to the PR. Before you merge this.
Status: NEW → ASSIGNED
Target Milestone: --- → FxOS-S6 (04Sep)
Merged as part of 
https://github.com/mozilla-b2g/gaia/commit/8c8f9093753f2101c9de9b51f04fead8d2e177c7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.