Closed
Bug 1200776
Opened 7 years ago
Closed 7 years ago
[Music][NGA] Overlays never appear on b2g-desktop
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S6 (04Sep)
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
Attachments
(1 file)
Music NGA is not showing the overlays on b2g-desktop. Its possible this is due to a race condition where the DB is triggering events *before* the listeners are attached. Regardless, an additional check should be added to query the DB status at startup to determine if any overlays need to be displayed.
Comment 1•7 years ago
|
||
I wonder if that's not the same reason as for bug 1198677
Comment 2•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jdarcangelo
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8655644 [details] [review] [gaia] justindarc:bug1200776 > mozilla-b2g:master Hub: This should fix the issue. We now explicitly request DB status during startup just in case we missed the window of opportunity for the events.
Attachment #8655644 -
Flags: review?(hub)
Comment 4•7 years ago
|
||
Comment on attachment 8655644 [details] [review] [gaia] justindarc:bug1200776 > mozilla-b2g:master Works great with my activity tests....
Attachment #8655644 -
Flags: review?(hub) → review+
Comment 5•7 years ago
|
||
Added an important comment to the PR. Before you merge this.
Status: NEW → ASSIGNED
Target Milestone: --- → FxOS-S6 (04Sep)
Comment 6•7 years ago
|
||
Merged as part of https://github.com/mozilla-b2g/gaia/commit/8c8f9093753f2101c9de9b51f04fead8d2e177c7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•