If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Numbers for --update-channel will break the regex for setting the new update channel

RESOLVED FIXED in Firefox 43

Status

Testing
Firefox UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

43 Branch
mozilla43
Points:
---

Firefox Tracking Flags

(firefox40 wontfix, firefox41 wontfix, firefox42 wontfix, firefox43 fixed, firefox-esr38 wontfix)

Details

(Whiteboard: [failure])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
A command like that will break the update tests:

> firefox-ui-update --binary /mozilla/bin/nightly/firefox --update-channel 1324

Traceback (most recent call last):
  File "/home/henrik/.virtualenvs/fxtests/local/lib/python2.7/site-packages/marionette_client-0.18-py2.7.egg/marionette/marionette_test.py", line 277, in run
    self.setUp()
  File "/mozilla/code/firefox-ui-tests/firefox_ui_tests/update/fallback/test_fallback_update.py", line 11, in setUp
    UpdateTestCase.setUp(self, is_fallback=True)
  File "/mozilla/code/firefox-ui-tests/firefox_ui_harness/testcases/update.py", line 66, in setUp
    'build_pre': self.software_update.build_info,
  File "/mozilla/code/firefox-ui-tests/firefox_puppeteer/api/software_update.py", line 229, in build_info
    'url_aus': self.get_update_url(True),
  File "/mozilla/code/firefox-ui-tests/firefox_puppeteer/api/software_update.py", line 354, in get_update_url
    url = url.replace('%CHANNEL%', self.update_channel.channel)
TypeError: coercing to Unicode: need string or buffer, NoneType found

We should handle invalid values more gracefully.
(Assignee)

Comment 1

2 years ago
Actually what's failing here is the re.sub() call:

new_content = re.sub(
            self.REGEX_UPDATE_CHANNEL, r'\1' + channel, self.file_contents)

In case of numbers it would look like r'\1324' which means the reference cannot be found anymore and as result the following content is written to the file: pref(K24");
(Assignee)

Comment 2

2 years ago
Fix is upcoming. So far it is not critical and I don't see why we would have to backport this patch.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
status-firefox40: --- → wontfix
status-firefox41: --- → wontfix
status-firefox42: --- → wontfix
status-firefox-esr38: --- → wontfix
Summary: Unknown values for --update-channel will break the update tests → Numbers for --update-channel will break the regex for setting the new update channel
(Assignee)

Comment 3

2 years ago
Created attachment 8655637 [details] [review]
github_pull_request.txt
Attachment #8655637 - Flags: review?(cmanchester)
Attachment #8655637 - Flags: review?(cmanchester) → review+
(Assignee)

Comment 4

2 years ago
Merged PR to master as: https://github.com/mozilla/firefox-ui-tests/commit/3a37fd6e9cf3568b8047cc7207d38d35f3f3acec
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.