Show compatibility error if an add-on uses the browser.newtab.url preference

VERIFIED FIXED in 2015-09-10

Status

VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: jorgev, Assigned: mstriemer)

Tracking

unspecified
2015-09-10

Details

(Whiteboard: [fx41])

(Reporter)

Description

3 years ago
As explained in bug 1118285, the browser.newtab.url preference will no longer be supported. All instances of that pref need to be flagged.

This is a compatibility error, so the add-on shouldn't be upgraded in this case. It should also appear as a warning in regular validations.

Message:

The browser.newtab.url preference has been removed. You can use the override function in NewTabURL.jsm instead. See <LINK> for more information.

Link: http://mxr.mozilla.org/mozilla-beta/source/browser/modules/NewTabURL.jsm

Affected add-on:

https://addons.mozilla.org/addon/searchload-options/

Release timing:

Firefox 41 will be released on September 22nd. Apologies for the late reports.
See Also: → bug 1200822
(Assignee)

Comment 1

3 years ago
https://github.com/mozilla/amo-validator/pull/325
Status: NEW → ASSIGNED

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/amo-validator

https://github.com/mozilla/amo-validator/commit/e40cfaf72f9a2b2590767a1479f71cfe7edcfaaf
Compat error for browser.newtab.url (bug 1200813)

https://github.com/mozilla/amo-validator/commit/9a8f9de73674b41f21b400a32765e2f18f058aba
Merge pull request #325 from mstriemer/browser.newtab.url-1200813

Compat error for browser.newtab.url (bug 1200813)
(Assignee)

Comment 3

3 years ago
https://github.com/mozilla/olympia/commit/dc4548efc70b6d3bc84e3303fc02c58a949dcbff
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 4

3 years ago
Verified as fixed : http://screencast.com/t/bnkBDDJJ
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.