Closed Bug 1200822 Opened 9 years ago Closed 9 years ago

NewTabURL.override() should raise a validator warning

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: TheOne, Assigned: mstriemer)

References

Details

As 'browser.newtab.url' is being replaced by 'NewTabURL.override()' (http://mxr.mozilla.org/mozilla-beta/source/browser/modules/NewTabURL.jsm) that one should raise a validator warning like 'browser.newtab.url' does.
Linked to 1200813
Assignee: nobody → mstriemer
See Also: → 1200813
What sort of warning should this generate? I don't quite understand.
Flags: needinfo?(awagner)
The validator should basically the same warning as the current 'browser.newtab.url' warning https://github.com/mozilla/amo-validator/blob/master/validator/testcases/javascript/predefinedentities.py#L129 https://github.com/mozilla/amo-validator/blob/master/validator/testcases/javascript/predefinedentities.py#L32 with signing severity 'high'.
Flags: needinfo?(awagner)
Right, good call.
Commits pushed to master at https://github.com/mozilla/amo-validator https://github.com/mozilla/amo-validator/commit/9e01a3e1cd4ead4ea6b32c1fa5d107e78f0df536 Warn about NewTabURL.override (bug 1200822) https://github.com/mozilla/amo-validator/commit/4eb033c8869c817dde3011020820d6faa7bf9bd7 Merge pull request #326 from mstriemer/NewTabURL.override-error-1200822 Warn about NewTabURL.override (bug 1200822)
https://github.com/mozilla/olympia/commit/dc4548efc70b6d3bc84e3303fc02c58a949dcbff
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
See Also: → 1214217
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.