Open Bug 1200857 Opened 9 years ago Updated 2 years ago

Markup-view doesn't switch to next element when you press Right if current element has no children except text node

Categories

(DevTools :: Inspector, defect, P3)

40 Branch
defect

Tracking

(firefox40 affected, firefox41 affected, firefox42 affected, firefox-esr38 unaffected)

REOPENED
Tracking Status
firefox40 --- affected
firefox41 --- affected
firefox42 --- affected
firefox-esr38 --- unaffected

People

(Reporter: arni2033, Unassigned)

References

()

Details

(Keywords: regression)

STR:   (Win7_64, Nightly 43, 32bit, ID 20150901030226, new profile, HWA off)
1. Open the followind "data:" URL (or click URL in form above)
data:text/html,<a>Firefox bug</a><div>second</div><b>third</b><br>
2. Right-click the text "Firefox bug", click "Inspect Element"
3. In markup-view click the selected element
4. Press Right several times

Result:       Nothing happens
Expectations: The next element should become selected.

Technically, this is regression, because in ESR 38 you have the ability to switch consequently through all elements of page in markup-view. But now text is no longer threated as a child element and now there's no such ability

Actually, I'm not sure that threating text NOT as child was a good idea (Not sure if it's not a bug)
This change was done in bug 892935.
It was a voluntary regression in order to save useful space in the markup-view and provide quicker preview of nodes without having to expand.
We were comforted that this was a good idea because both firebug and chrome did it too (in fact this bug was part of meta bug firebug-gaps).

I'm not sure that the use case to select a text node in the markup-view is compelling enough, and we haven't had any other feedback about this so far.
Therefore, I don't think we should revert this change, so I will flag this as WONTFIX for now.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #1)
> I'm not sure that the use case to select a text node in the markup-view is compelling enough
My report is NOT about selecting a text node, but about Right key not working properly. If the element has not children, then Right key should work like Down key. If I try pressing Right on the elements in markup on the following page, I get expected result - switching through all elements successively:
>      data:text/html,<a></a><div></div><b></b><br>
So, current behavior of Right key in markup is inconsistent. (maybe I've poorly clarified this)
Anyway it's different from selecting text node. Please close this as well, if you think that Right key should behave like it does now.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
I suppose that when I press Right, markup-view observes whether current element have children or not, and if it has no children, then it switches to the next element. If it has children, then markup-view switches to the 1st child. But due to bug 892935 switching to text element is disabled, therefore markup-view just does nothing. Before deleting text as child node, this mechanism worked fine.
I think now it should be modified to work again
Flags: needinfo?(pbrosset)
My bad, sorry about that.
I agree we should change this.
Flags: needinfo?(pbrosset)
Blocks: 892935
Has STR: --- → yes
Bug triage (filter on CLIMBING SHOES).
Priority: -- → P3
Product: Firefox → DevTools
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.