1200861 - Lightning repacks get fooled by interfaces.manifest generated from make export

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

When doing l10n repacks on beta, make export is now called, which generates objdir-l10n/dist/xpi-stage/lightning/components/interfaces.manifest. The current lightning packager checks for the existence of objdir-l10n/dist/xpi-stage/lightning so it will work when not called from the l10n repacks but locally, without overwriting the generated lightning.

The upcoming patch will check if EN_US_BINARY_URL is finally set and then go about downloading and unpacking unconditionally. I've tested this locally with a script that emulates the l10n repacks, for the case that xpi-stage/lightning does not exist at all, and for the case where it contains just the interfaces.manifest.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8655710 [details] [diff] [review]
Fix - v1

Review of attachment 8655710 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset a69ff7e5e57b

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset 39de7d8e88d4

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-beta changeset 88062c7a9dc0

Comment 6

[Stefan Sitter [:ssitter]]

All builds are broken on all 3 branches:

/builds/slave/tb-c-cen-lx-000000000000000000/build/calendar/lightning/lightning-packager.mk:58: *** You must set EN_US_BINARY_URL. Stop.
make[4]: *** [calendar/providers/gdata/export] Error 2

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Sorry about that. Taking care!

Comment 8

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23040
repository: comm-central
start_time: 2015-09-02T04:05:25
who: mozilla[at]kewis[dot]ch
machine: bld-lion-r5-073
buildname: TB OS X 10.7 64-bit comm-central leak test build
revision: a69ff7e5e57b

CalledProcessError: Command '['hg', 'log', '-r', u'a69ff7e5e57b463075aaec4fb063cb1384ecc146', '--template', '{node}']' returned non-zero exit status 255
make[4]: *** [calendar/providers/gdata/export] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [export] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 9

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23041
repository: comm-central
start_time: 2015-09-02T04:05:26
who: mozilla[at]kewis[dot]ch
machine: bld-linux64-spot-363
buildname: TB Linux x86-64 comm-central build
revision: a69ff7e5e57b

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[4]: *** [calendar/providers/gdata/export] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [export] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23035
repository: comm-central
start_time: 2015-09-02T04:05:25
who: mozilla[at]kewis[dot]ch
machine: b-2008-ix-0106
buildname: TB WINNT 5.2 comm-central build
revision: a69ff7e5e57b

mozmake.exe[4]: *** [calendar/providers/gdata/export] Error 2
mozmake.exe[4]: *** Waiting for unfinished jobs....
mozmake.exe[3]: *** [export] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23038
repository: comm-central
start_time: 2015-09-02T04:05:27
who: mozilla[at]kewis[dot]ch
machine: bld-linux64-spot-407
buildname: TB Linux comm-central build
revision: a69ff7e5e57b

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[4]: *** [calendar/providers/gdata/export] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [export] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 12

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23036
repository: comm-central
start_time: 2015-09-02T04:05:27
who: mozilla[at]kewis[dot]ch
machine: bld-linux64-spot-404
buildname: TB Linux x86-64 comm-central leak test build
revision: a69ff7e5e57b

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[4]: *** [calendar/providers/gdata/export] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [export] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23034
repository: comm-central
start_time: 2015-09-02T04:05:27
who: mozilla[at]kewis[dot]ch
machine: bld-linux64-spot-1079
buildname: TB Linux comm-central leak test build
revision: a69ff7e5e57b

IOError: [Errno 2] No such file or directory: '/usr/local/lib/hgext/bundleclone.py'
make[4]: *** [calendar/providers/gdata/export] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [export] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 14

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23037
repository: comm-central
start_time: 2015-09-02T04:05:25
who: mozilla[at]kewis[dot]ch
machine: b-2008-ix-0094
buildname: TB WINNT 5.2 comm-central leak test build
revision: a69ff7e5e57b

mozmake.exe[4]: *** [calendar/providers/gdata/export] Error 2
mozmake.exe[4]: *** Waiting for unfinished jobs....
mozmake.exe[3]: *** [export] Error 2
mozmake.exe[2]: *** [default] Error 2
mozmake.exe[1]: *** [build] Error 2
mozmake.exe: *** [build] Error 2

Comment 15

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=23039
repository: comm-central
start_time: 2015-09-02T04:05:29
who: mozilla[at]kewis[dot]ch
machine: bld-lion-r5-066
buildname: TB OS X 10.7 comm-central build
revision: a69ff7e5e57b

make[5]: *** [calendar/providers/gdata/export] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [export] Error 2
make[3]: *** [default] Error 2
make[2]: *** [build] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 16

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I've pushed a bustage fix with rs=Callek: https://hg.mozilla.org/comm-central/rev/6bcf01ef7591

Waiting for green c-c before I backport this.

Comment 17

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Linux is green, that is good enough for me. Here we go:

https://hg.mozilla.org/releases/comm-aurora/rev/069a4fdedeb1
https://hg.mozilla.org/releases/comm-beta/rev/409957bf2393