The default bug view has changed. See this FAQ.

Lightning repacks get fooled by interfaces.manifest generated from make export

RESOLVED FIXED in 4.3

Status

Calendar
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Trunk

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
When doing l10n repacks on beta, make export is now called, which generates objdir-l10n/dist/xpi-stage/lightning/components/interfaces.manifest. The current lightning packager checks for the existence of objdir-l10n/dist/xpi-stage/lightning so it will work when not called from the l10n repacks but locally, without overwriting the generated lightning.

The upcoming patch will check if EN_US_BINARY_URL is finally set and then go about downloading and unpacking unconditionally. I've tested this locally with a script that emulates the l10n repacks, for the case that xpi-stage/lightning does not exist at all, and for the case where it contains just the interfaces.manifest.
(Assignee)

Updated

2 years ago
Blocks: 1199390
(Assignee)

Comment 1

2 years ago
Created attachment 8655710 [details] [diff] [review]
Fix - v1
Attachment #8655710 - Flags: review?(mkmelin+mozilla)
Attachment #8655710 - Flags: approval-calendar-beta+
Attachment #8655710 - Flags: approval-calendar-aurora+

Comment 2

2 years ago
Comment on attachment 8655710 [details] [diff] [review]
Fix - v1

Review of attachment 8655710 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me
Attachment #8655710 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 3

2 years ago
Pushed to comm-central changeset a69ff7e5e57b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.5
(Assignee)

Comment 4

2 years ago
Backported to releases/comm-aurora changeset 39de7d8e88d4
Target Milestone: 4.5 → 4.4
(Assignee)

Comment 5

2 years ago
Backported to releases/comm-beta changeset 88062c7a9dc0
Target Milestone: 4.4 → 4.3

Comment 6

2 years ago
All builds are broken on all 3 branches:

/builds/slave/tb-c-cen-lx-000000000000000000/build/calendar/lightning/lightning-packager.mk:58: *** You must set EN_US_BINARY_URL. Stop.
make[4]: *** [calendar/providers/gdata/export] Error 2
Flags: needinfo?(philipp)
(Assignee)

Comment 7

2 years ago
Sorry about that. Taking care!
Status: RESOLVED → REOPENED
Flags: needinfo?(philipp)
Resolution: FIXED → ---
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 16

2 years ago
I've pushed a bustage fix with rs=Callek: https://hg.mozilla.org/comm-central/rev/6bcf01ef7591

Waiting for green c-c before I backport this.
(Assignee)

Comment 17

2 years ago
Linux is green, that is good enough for me. Here we go:

https://hg.mozilla.org/releases/comm-aurora/rev/069a4fdedeb1
https://hg.mozilla.org/releases/comm-beta/rev/409957bf2393
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.